Re: [PATCH] perf annotate: Don't prepend symfs path to build_id_filename

2018-03-13 Thread Martin Vuille
On 03/09/18 14:07, Arnaldo Carvalho de Melo wrote: Em Sun, Feb 11, 2018 at 02:19:37PM -0500, Martin Vuille escreveu: build_id_filename already contains symfs path if applicable, so don't prepend it a second time. Where is the analysis that shows that that is the case? I looked here at the imple

Re: [PATCH] perf annotate: Don't prepend symfs path to build_id_filename

2018-03-09 Thread Martin Vuille
dso__build_id_filename calls build_id_cache__linkname build_id_cache__linkname uses buildid_dir symbol__config_symfs includes the symfs directory in buildid_dir So it's not necessary to prepend it again. Should've included those notes in the original submission. Will do better next time. MV

Re: [PATCH] perf annotate: Don't prepend symfs path to build_id_filename

2018-03-09 Thread Arnaldo Carvalho de Melo
Em Sun, Feb 11, 2018 at 02:19:37PM -0500, Martin Vuille escreveu: > build_id_filename already contains symfs path if applicable, so > don't prepend it a second time. Where is the analysis that shows that that is the case? I looked here at the implementation for dso__build_id_filename() and couldn'

[PATCH] perf annotate: Don't prepend symfs path to build_id_filename

2018-02-11 Thread Martin Vuille
build_id_filename already contains symfs path if applicable, so don't prepend it a second time. Signed-off-by: Martin Vuille --- tools/perf/util/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c index 28b233c3dc