Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.

2015-06-22 Thread Arnaldo Carvalho de Melo
Em Sat, Jun 20, 2015 at 01:53:47PM +0200, Martin Liška escreveu: > On 06/19/2015 09:10 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Jun 19, 2015 at 11:35:41AM +0200, Martin Liška escreveu: > >> Thank you for the review, all remarks were reasonable. > >> Feel free to comment next version (v3) of

Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.

2015-06-20 Thread Martin Liška
On 06/19/2015 09:10 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Jun 19, 2015 at 11:35:41AM +0200, Martin Liška escreveu: >> Thank you for the review, all remarks were reasonable. >> Feel free to comment next version (v3) of the patch. > > Thanks, there was just one missing s/tuples/samples/g, I

Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.

2015-06-19 Thread Arnaldo Carvalho de Melo
Em Fri, Jun 19, 2015 at 11:35:41AM +0200, Martin Liška escreveu: > Thank you for the review, all remarks were reasonable. > Feel free to comment next version (v3) of the patch. Thanks, there was just one missing s/tuples/samples/g, I did it and tried running git-am on the attached patch, it failed

Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.

2015-06-19 Thread Martin Liška
>>> annotated >>> output too) > >> Thanks for note, I fixed that by introducing a new 't' hot key. > >> >From 98e1998fcd7481c7e1756e643d66eb85559849ac Mon Sep 17 00:00:00 2001 >> From: mliska >> Date: Wed, 27 May 2015 10:54:42 +0200 >> Subject

Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.

2015-06-18 Thread Arnaldo Carvalho de Melo
x27;t' hot key. > >From 98e1998fcd7481c7e1756e643d66eb85559849ac Mon Sep 17 00:00:00 2001 > From: mliska > Date: Wed, 27 May 2015 10:54:42 +0200 > Subject: [PATCH] perf annotate: With --show-total-period, display total # of > samples. > > To compare two records o

Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.

2015-06-18 Thread Martin Liška
hat is the toggle for this in the 'perf report' TUI? (which displays > annotated > output too) > > Thanks, > > Ingo > Hello. Thanks for note, I fixed that by introducing a new 't' hot key. Thanks, Martin >From 98e1998fcd7481c7e1756e643d66eb85559849ac Mon Sep 17

Re: [PATCH] perf annotate: With --show-total-period, display total # of samples.

2015-06-18 Thread Ingo Molnar
* Martin Liška wrote: > To compare two records on an instruction base, with --show-total-period > option provided, display total number of samples that belong to a line > in assembly language. > > Signed-off-by: Martin Liska > --- > tools/perf/builtin-annotate.c | 2 ++ > tools/perf/ui/b

[PATCH] perf annotate: With --show-total-period, display total # of samples.

2015-06-18 Thread Martin Liška
To compare two records on an instruction base, with --show-total-period option provided, display total number of samples that belong to a line in assembly language. Signed-off-by: Martin Liska --- tools/perf/builtin-annotate.c | 2 ++ tools/perf/ui/browsers/annotate.c | 44 +