Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-15 Thread John Garry
I decided not to do any rebase on perf/core, so those Fixes will remain valid. Ah, ok. Then that should be fine wrt fixes tags. Cheers, John

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-15 Thread Arnaldo Carvalho de Melo
Em Wed, Oct 14, 2020 at 06:46:12PM +0100, John Garry escreveu: > On 14/10/2020 17:49, Arnaldo Carvalho de Melo wrote: > > Ok, applied, > > Thanks > > > please consider adding a Fixes tag next time. > > > > Can do if it helps, but I only thought it appropriate when fixing something > merged to m

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-14 Thread John Garry
On 14/10/2020 17:49, Arnaldo Carvalho de Melo wrote: Ok, applied, Thanks please consider adding a Fixes tag next time. Can do if it helps, but I only thought it appropriate when fixing something merged to mainline. John

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-14 Thread Arnaldo Carvalho de Melo
Em Mon, Oct 12, 2020 at 01:24:19PM +0200, Jiri Olsa escreveu: > On Mon, Oct 12, 2020 at 12:15:04PM +0100, John Garry wrote: > > On 12/10/2020 11:54, Jiri Olsa wrote: > > > > ff --git a/tools/perf/pmu-events/jevents.c > > > > b/tools/perf/pmu-events/jevents.c > > > > index 99df41a9543d..e47644cab3f

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-13 Thread John Garry
On 12/10/2020 12:24, Jiri Olsa wrote: On Mon, Oct 12, 2020 at 12:15:04PM +0100, John Garry wrote: On 12/10/2020 11:54, Jiri Olsa wrote: ff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c index 99df41a9543d..e47644cab3fa 100644 --- a/tools/perf/pmu-events/jevents.c +++

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-12 Thread Jiri Olsa
On Mon, Oct 12, 2020 at 12:15:04PM +0100, John Garry wrote: > On 12/10/2020 11:54, Jiri Olsa wrote: > > > ff --git a/tools/perf/pmu-events/jevents.c > > > b/tools/perf/pmu-events/jevents.c > > > index 99df41a9543d..e47644cab3fa 100644 > > > --- a/tools/perf/pmu-events/jevents.c > > > +++ b/tools/p

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-12 Thread John Garry
On 12/10/2020 11:54, Jiri Olsa wrote: ff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c index 99df41a9543d..e47644cab3fa 100644 --- a/tools/perf/pmu-events/jevents.c +++ b/tools/perf/pmu-events/jevents.c @@ -505,20 +505,15 @@ static char *real_event(const char *name, ch

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-12 Thread Jiri Olsa
On Thu, Oct 08, 2020 at 11:19:28PM +0800, John Garry wrote: > The event code for events referencing std arch events is incorrectly > evaluated in json_events(). > > The issue is that je.event is evaluated properly from try_fixup(), but > later NULLified from the real_event() call, as "event" may b

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-09 Thread John Garry
On 09/10/2020 12:26, kajoljain wrote: On 10/8/20 8:49 PM, John Garry wrote: The event code for events referencing std arch events is incorrectly evaluated in json_events(). The issue is that je.event is evaluated properly from try_fixup(), but later NULLified from the real_event() call, as "ev

Re: [PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-09 Thread kajoljain
On 10/8/20 8:49 PM, John Garry wrote: > The event code for events referencing std arch events is incorrectly > evaluated in json_events(). > > The issue is that je.event is evaluated properly from try_fixup(), but > later NULLified from the real_event() call, as "event" may be NULL. > > Fix by

[PATCH] perf jevents: Fix event code for events referencing std arch events

2020-10-08 Thread John Garry
The event code for events referencing std arch events is incorrectly evaluated in json_events(). The issue is that je.event is evaluated properly from try_fixup(), but later NULLified from the real_event() call, as "event" may be NULL. Fix by setting "event" same je.event in try_fixup(). Also re