Re: [PATCH] perf parse-events: Make add PMU verbose output clearer

2020-05-13 Thread Jiri Olsa
On Tue, May 12, 2020 at 05:17:29PM -0700, Ian Rogers wrote: SNIP > diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c > index 92bd7fafcce6..71d0290b616a 100644 > --- a/tools/perf/util/pmu.c > +++ b/tools/perf/util/pmu.c > @@ -1056,7 +1056,8 @@ static char *pmu_formats_string(struct

[PATCH] perf parse-events: Make add PMU verbose output clearer

2020-05-12 Thread Ian Rogers
On a CPU like skylakex an uncore_iio_0 PMU may alias with uncore_iio_free_running_0. The latter PMU doesn't support fc_mask as a parameter and so pmu_config_term fails. Typically parse_events_add_pmu is called in a loop where if one alias succeeds errors are ignored, however, if multiple errors