Re: [PATCH] perf parse-events: report bpf errors

2020-07-10 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 08, 2020 at 08:47:32PM +0200, Jiri Olsa escreveu: > On Tue, Jul 07, 2020 at 02:14:49PM -0700, Ian Rogers wrote: > > Setting the parse_events_error directly doesn't increment num_errors > > causing the error message not to be displayed. Use the > > parse_events__handle_error function tha

Re: [PATCH] perf parse-events: report bpf errors

2020-07-08 Thread Jiri Olsa
On Tue, Jul 07, 2020 at 02:14:49PM -0700, Ian Rogers wrote: > Setting the parse_events_error directly doesn't increment num_errors > causing the error message not to be displayed. Use the > parse_events__handle_error function that sets num_errors and handle > multiple errors. > > Signed-off-by: Ia

Re: [PATCH] perf parse-events: report bpf errors

2020-07-08 Thread Arnaldo Carvalho de Melo
Em Wed, Jul 08, 2020 at 08:15:24AM -0700, Ian Rogers escreveu: > On Wed, Jul 8, 2020 at 4:19 AM Arnaldo Carvalho de Melo > wrote: > > Em Tue, Jul 07, 2020 at 02:14:49PM -0700, Ian Rogers escreveu: > > > Setting the parse_events_error directly doesn't increment num_errors > > > causing the error m

Re: [PATCH] perf parse-events: report bpf errors

2020-07-08 Thread Ian Rogers
On Wed, Jul 8, 2020 at 4:19 AM Arnaldo Carvalho de Melo wrote: > > Em Tue, Jul 07, 2020 at 02:14:49PM -0700, Ian Rogers escreveu: > > Setting the parse_events_error directly doesn't increment num_errors > > causing the error message not to be displayed. Use the > > parse_events__handle_error funct

Re: [PATCH] perf parse-events: report bpf errors

2020-07-08 Thread Arnaldo Carvalho de Melo
Em Tue, Jul 07, 2020 at 02:14:49PM -0700, Ian Rogers escreveu: > Setting the parse_events_error directly doesn't increment num_errors > causing the error message not to be displayed. Use the > parse_events__handle_error function that sets num_errors and handle > multiple errors. What was the comma

[PATCH] perf parse-events: report bpf errors

2020-07-07 Thread Ian Rogers
Setting the parse_events_error directly doesn't increment num_errors causing the error message not to be displayed. Use the parse_events__handle_error function that sets num_errors and handle multiple errors. Signed-off-by: Ian Rogers --- tools/perf/util/parse-events.c | 38 ++---