Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-16 Thread Masami Hiramatsu
On Thu, 16 Mar 2017 20:07:08 +0800 Kefeng Wang wrote: > > > On 2017/3/16 17:39, Masami Hiramatsu wrote: > > On Tue, 14 Mar 2017 10:30:56 -0300 > > Arnaldo Carvalho de Melo wrote: > > > >> Em Tue, Mar 14, 2017 at 09:19:47PM +0800, Kefeng Wang

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-16 Thread Masami Hiramatsu
On Thu, 16 Mar 2017 20:07:08 +0800 Kefeng Wang wrote: > > > On 2017/3/16 17:39, Masami Hiramatsu wrote: > > On Tue, 14 Mar 2017 10:30:56 -0300 > > Arnaldo Carvalho de Melo wrote: > > > >> Em Tue, Mar 14, 2017 at 09:19:47PM +0800, Kefeng Wang escreveu: > >>> Hi all, any comments, thanks. > >>

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-16 Thread Kefeng Wang
On 2017/3/16 17:39, Masami Hiramatsu wrote: > On Tue, 14 Mar 2017 10:30:56 -0300 > Arnaldo Carvalho de Melo wrote: > >> Em Tue, Mar 14, 2017 at 09:19:47PM +0800, Kefeng Wang escreveu: >>> Hi all, any comments, thanks. >> >> For 'perf probe' make sure Masami is in the CC list,

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-16 Thread Kefeng Wang
On 2017/3/16 17:39, Masami Hiramatsu wrote: > On Tue, 14 Mar 2017 10:30:56 -0300 > Arnaldo Carvalho de Melo wrote: > >> Em Tue, Mar 14, 2017 at 09:19:47PM +0800, Kefeng Wang escreveu: >>> Hi all, any comments, thanks. >> >> For 'perf probe' make sure Masami is in the CC list, adding him,

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-16 Thread Masami Hiramatsu
On Tue, 14 Mar 2017 10:30:56 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 14, 2017 at 09:19:47PM +0800, Kefeng Wang escreveu: > > Hi all, any comments, thanks. > > For 'perf probe' make sure Masami is in the CC list, adding him, Masami? Thanks Arnaldo, Hi Kefeng, I've

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-16 Thread Masami Hiramatsu
On Tue, 14 Mar 2017 10:30:56 -0300 Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 14, 2017 at 09:19:47PM +0800, Kefeng Wang escreveu: > > Hi all, any comments, thanks. > > For 'perf probe' make sure Masami is in the CC list, adding him, Masami? Thanks Arnaldo, Hi Kefeng, I've made the error

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-14 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 14, 2017 at 09:19:47PM +0800, Kefeng Wang escreveu: > Hi all, any comments, thanks. For 'perf probe' make sure Masami is in the CC list, adding him, Masami? - Arnaldo > On 2017/3/7 15:33, Kefeng Wang wrote: > > + Arnaldo Carvalho de Melo > > > > On 2017/3/6

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-14 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 14, 2017 at 09:19:47PM +0800, Kefeng Wang escreveu: > Hi all, any comments, thanks. For 'perf probe' make sure Masami is in the CC list, adding him, Masami? - Arnaldo > On 2017/3/7 15:33, Kefeng Wang wrote: > > + Arnaldo Carvalho de Melo > > > > On 2017/3/6 17:34, Kefeng Wang

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-14 Thread Kefeng Wang
Hi all, any comments, thanks. On 2017/3/7 15:33, Kefeng Wang wrote: > + Arnaldo Carvalho de Melo > > On 2017/3/6 17:34, Kefeng Wang wrote: >> On old perf, when using perf probe -d to delete an inexistent event, >> it return errno, eg, >> >> -bash-4.3# perf probe -d xxx || echo

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-14 Thread Kefeng Wang
Hi all, any comments, thanks. On 2017/3/7 15:33, Kefeng Wang wrote: > + Arnaldo Carvalho de Melo > > On 2017/3/6 17:34, Kefeng Wang wrote: >> On old perf, when using perf probe -d to delete an inexistent event, >> it return errno, eg, >> >> -bash-4.3# perf probe -d xxx || echo $? >> Info:

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-06 Thread Kefeng Wang
+ Arnaldo Carvalho de Melo On 2017/3/6 17:34, Kefeng Wang wrote: > On old perf, when using perf probe -d to delete an inexistent event, > it return errno, eg, > > -bash-4.3# perf probe -d xxx || echo $? > Info: Event "*:xxx" does not exist. > Error: Failed to delete events.

Re: [PATCH] perf probe: Return errno when does not hit any event

2017-03-06 Thread Kefeng Wang
+ Arnaldo Carvalho de Melo On 2017/3/6 17:34, Kefeng Wang wrote: > On old perf, when using perf probe -d to delete an inexistent event, > it return errno, eg, > > -bash-4.3# perf probe -d xxx || echo $? > Info: Event "*:xxx" does not exist. > Error: Failed to delete events. > 255 > > But

[PATCH] perf probe: Return errno when does not hit any event

2017-03-06 Thread Kefeng Wang
On old perf, when using perf probe -d to delete an inexistent event, it return errno, eg, -bash-4.3# perf probe -d xxx || echo $? Info: Event "*:xxx" does not exist. Error: Failed to delete events. 255 But now perf_del_probe_events() will always set ret = 0, different from previous

[PATCH] perf probe: Return errno when does not hit any event

2017-03-06 Thread Kefeng Wang
On old perf, when using perf probe -d to delete an inexistent event, it return errno, eg, -bash-4.3# perf probe -d xxx || echo $? Info: Event "*:xxx" does not exist. Error: Failed to delete events. 255 But now perf_del_probe_events() will always set ret = 0, different from previous