Re: [PATCH] perf record: Synthesize cgroup events only if needed

2020-11-30 Thread Namhyung Kim
Hi Arnaldo, On Sat, Nov 28, 2020 at 2:30 AM Arnaldo Carvalho de Melo wrote: > > Em Fri, Nov 27, 2020 at 04:45:57PM +0100, Jiri Olsa escreveu: > > On Fri, Nov 27, 2020 at 02:43:56PM +0900, Namhyung Kim wrote: > > > It didn't check the tool->cgroup_events bit which is set when > > > the --all-cgrou

Re: [PATCH] perf record: Synthesize cgroup events only if needed

2020-11-30 Thread Namhyung Kim
Hi Jiri, On Sat, Nov 28, 2020 at 12:46 AM Jiri Olsa wrote: > > On Fri, Nov 27, 2020 at 02:43:56PM +0900, Namhyung Kim wrote: > > It didn't check the tool->cgroup_events bit which is set when > > the --all-cgroups option is given. Without it, samples will not have > > cgroup info so no reason to

Re: [PATCH] perf record: Synthesize cgroup events only if needed

2020-11-27 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 27, 2020 at 04:45:57PM +0100, Jiri Olsa escreveu: > On Fri, Nov 27, 2020 at 02:43:56PM +0900, Namhyung Kim wrote: > > It didn't check the tool->cgroup_events bit which is set when > > the --all-cgroups option is given. Without it, samples will not have > > cgroup info so no reason to s

Re: [PATCH] perf record: Synthesize cgroup events only if needed

2020-11-27 Thread Jiri Olsa
On Fri, Nov 27, 2020 at 02:43:56PM +0900, Namhyung Kim wrote: > It didn't check the tool->cgroup_events bit which is set when > the --all-cgroups option is given. Without it, samples will not have > cgroup info so no reason to synthesize. > > We can check the PERF_RECORD_CGROUP records after runn

[PATCH] perf record: Synthesize cgroup events only if needed

2020-11-26 Thread Namhyung Kim
It didn't check the tool->cgroup_events bit which is set when the --all-cgroups option is given. Without it, samples will not have cgroup info so no reason to synthesize. We can check the PERF_RECORD_CGROUP records after running perf record *WITHOUT* the --all-cgroups option: Before: $ perf re