Re: [PATCH] perf report: fix memory leak in addr2line when called by addr2inlines

2017-05-17 Thread Milian Wolff
On Wednesday, May 17, 2017 6:20:49 AM CEST Namhyung Kim wrote: > On Tue, May 16, 2017 at 11:53:59PM +0200, Milian Wolff wrote: > > When a filename was found in addr2line it was duplicated via strdup > > but never freed. Now we pass NULL and handle this gracefully in > > addr2line. > > > > Detected

Re: [PATCH] perf report: fix memory leak in addr2line when called by addr2inlines

2017-05-16 Thread Namhyung Kim
On Tue, May 16, 2017 at 11:53:59PM +0200, Milian Wolff wrote: > When a filename was found in addr2line it was duplicated via strdup > but never freed. Now we pass NULL and handle this gracefully in > addr2line. > > Detected by Valgrind: > > ==16331== 1,680 bytes in 21 blocks are definitely lost i

[PATCH] perf report: fix memory leak in addr2line when called by addr2inlines

2017-05-16 Thread Milian Wolff
When a filename was found in addr2line it was duplicated via strdup but never freed. Now we pass NULL and handle this gracefully in addr2line. Detected by Valgrind: ==16331== 1,680 bytes in 21 blocks are definitely lost in loss record 148 of 220 ==16331==at 0x4C2AF1F: malloc (in /usr/lib/val