Re: [PATCH] perf stat: Fix uncore event mixed metric with workload error issue

2020-04-29 Thread Jin, Yao
Hi Jiri, On 4/29/2020 4:16 PM, Jiri Olsa wrote: On Tue, Apr 28, 2020 at 02:19:22PM -0700, Andi Kleen wrote: I wonder this would break some expectations.. would it be more safe to detect duration event and bypass it from the decission? but maybe the case I'm worried about is not a problem at all

Re: [PATCH] perf stat: Fix uncore event mixed metric with workload error issue

2020-04-29 Thread Jiri Olsa
On Tue, Apr 28, 2020 at 02:19:22PM -0700, Andi Kleen wrote: > > I wonder this would break some expectations.. would it be > > more safe to detect duration event and bypass it from the > > decission? but maybe the case I'm worried about is not a > > problem at all.. Andi? > > Don't see what it woul

Re: [PATCH] perf stat: Fix uncore event mixed metric with workload error issue

2020-04-28 Thread Andi Kleen
> I wonder this would break some expectations.. would it be > more safe to detect duration event and bypass it from the > decission? but maybe the case I'm worried about is not a > problem at all.. Andi? Don't see what it would break. Yes maybe we need to special case duration_time more, but that

Re: [PATCH] perf stat: Fix uncore event mixed metric with workload error issue

2020-04-28 Thread Jiri Olsa
On Mon, Apr 27, 2020 at 10:41:16PM +0800, Jin Yao wrote: SNIP > index 9207b6c45475..b01ee06b1965 100644 > --- a/tools/perf/builtin-stat.c > +++ b/tools/perf/builtin-stat.c > @@ -1841,8 +1841,8 @@ static void setup_system_wide(int forks) >* conditions is met: >* >* - ther