Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator

2019-01-29 Thread Arnaldo Carvalho de Melo
Em Wed, Jan 23, 2019 at 09:33:38AM +0100, Jiri Olsa escreveu: > On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote: > > Notice that the use of the bitwise OR operator '|' always leads to > > true in this particular case, which seems a bit suspicious due to > > the context in which

Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator

2019-01-28 Thread Gustavo A. R. Silva
Hi all, Friendly ping: Who can take this? Thanks -- Gustavo On 1/23/19 2:40 AM, Gustavo A. R. Silva wrote: > > > On 1/23/19 2:33 AM, Jiri Olsa wrote: >> On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote: >>> Notice that the use of the bitwise OR operator '|' always leads to

Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator

2019-01-23 Thread Gustavo A. R. Silva
On 1/23/19 2:33 AM, Jiri Olsa wrote: > On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote: >> Notice that the use of the bitwise OR operator '|' always leads to >> true in this particular case, which seems a bit suspicious due to >> the context in which this expression is being

Re: [PATCH] perf tests: evsel-tp-sched: Fix bitwise operator

2019-01-23 Thread Jiri Olsa
On Tue, Jan 22, 2019 at 05:34:39PM -0600, Gustavo A. R. Silva wrote: > Notice that the use of the bitwise OR operator '|' always leads to > true in this particular case, which seems a bit suspicious due to > the context in which this expression is being used. > > Fix this by using bitwise AND oper

[PATCH] perf tests: evsel-tp-sched: Fix bitwise operator

2019-01-22 Thread Gustavo A. R. Silva
Notice that the use of the bitwise OR operator '|' always leads to true in this particular case, which seems a bit suspicious due to the context in which this expression is being used. Fix this by using bitwise AND operator '&' instead. This bug was detected with the help of Coccinelle. Fixes: 6