Re: [PATCH] perf tool sort: Use default sort if evlist is empty

2017-07-26 Thread Arnaldo Carvalho de Melo
Em Thu, Jul 20, 2017 at 10:11:57PM -0700, David Carrillo-Cisneros escreveu: > Fixes bug noted by Jiri in https://lkml.org/lkml/2017/6/13/755 and caused > by commit d49dadea7862 ("perf tools: Make 'trace' or 'trace_fields' sort >key default for tracepoint events") > not taking into account that

Re: [PATCH] perf tool sort: Use default sort if evlist is empty

2017-07-24 Thread David Carrillo-Cisneros
On Sat, Jul 22, 2017 at 4:09 PM, Namhyung Kim wrote: > On Fri, Jul 21, 2017 at 01:02:50PM -0700, David Carrillo-Cisneros wrote: >> On Fri, Jul 21, 2017 at 12:44 AM, Jiri Olsa wrote: >> > On Thu, Jul 20, 2017 at 10:11:57PM -0700, David Carrillo-Cisneros wrote: >> >> Fixes bug noted by Jiri in http

Re: [PATCH] perf tool sort: Use default sort if evlist is empty

2017-07-24 Thread Jiri Olsa
On Sun, Jul 23, 2017 at 08:09:49AM +0900, Namhyung Kim wrote: SNIP > > > also I've got another crash for (added -a option for above example): > > > > > > [root@krava perf]# ./perf record -e 'sched:sched_switch' -a sleep > > > 1 | ./perf report > > > # To display the perf.data he

Re: [PATCH] perf tool sort: Use default sort if evlist is empty

2017-07-22 Thread Namhyung Kim
On Fri, Jul 21, 2017 at 01:02:50PM -0700, David Carrillo-Cisneros wrote: > On Fri, Jul 21, 2017 at 12:44 AM, Jiri Olsa wrote: > > On Thu, Jul 20, 2017 at 10:11:57PM -0700, David Carrillo-Cisneros wrote: > >> Fixes bug noted by Jiri in https://lkml.org/lkml/2017/6/13/755 and caused > >> by commit d

Re: [PATCH] perf tool sort: Use default sort if evlist is empty

2017-07-21 Thread David Carrillo-Cisneros
On Fri, Jul 21, 2017 at 12:44 AM, Jiri Olsa wrote: > On Thu, Jul 20, 2017 at 10:11:57PM -0700, David Carrillo-Cisneros wrote: >> Fixes bug noted by Jiri in https://lkml.org/lkml/2017/6/13/755 and caused >> by commit d49dadea7862 ("perf tools: Make 'trace' or 'trace_fields' sort >>key default f

Re: [PATCH] perf tool sort: Use default sort if evlist is empty

2017-07-21 Thread Jiri Olsa
On Thu, Jul 20, 2017 at 10:11:57PM -0700, David Carrillo-Cisneros wrote: > Fixes bug noted by Jiri in https://lkml.org/lkml/2017/6/13/755 and caused > by commit d49dadea7862 ("perf tools: Make 'trace' or 'trace_fields' sort >key default for tracepoint events") > not taking into account that evl

[PATCH] perf tool sort: Use default sort if evlist is empty

2017-07-20 Thread David Carrillo-Cisneros
Fixes bug noted by Jiri in https://lkml.org/lkml/2017/6/13/755 and caused by commit d49dadea7862 ("perf tools: Make 'trace' or 'trace_fields' sort key default for tracepoint events") not taking into account that evlist is empty in pipe-mode. Before this commit, pipe mode will only show bogus "1