Re: [PATCH] perf tools: Fix pthread_attr_setaffinity_np() feature detection on Ubuntu systems

2015-03-01 Thread Ingo Molnar
* Jiri Olsa wrote: > agreed, sry about that.. I'll try to clean it up while moving > features detection into tools/ as you suggested before That would be nice! > > --- a/tools/perf/config/feature-checks/test-pthread-attr-setaffinity-np.c > > +++

Re: [PATCH] perf tools: Fix pthread_attr_setaffinity_np() feature detection on Ubuntu systems

2015-03-01 Thread Ingo Molnar
* Jiri Olsa jo...@redhat.com wrote: agreed, sry about that.. I'll try to clean it up while moving features detection into tools/ as you suggested before That would be nice! --- a/tools/perf/config/feature-checks/test-pthread-attr-setaffinity-np.c +++

Re: [PATCH] perf tools: Fix pthread_attr_setaffinity_np() feature detection on Ubuntu systems

2015-02-28 Thread Jiri Olsa
On Sat, Feb 28, 2015 at 08:49:27AM +0100, Ingo Molnar wrote: SNIP > > 0695e57b9a6a perf tools: Factor features display code > > Firstly, 'factor' isn't a verb we use for code, 'factor out' is. But > it's not really factoring out - it separates the code. Did this title > want to say: > >

Re: [PATCH] perf tools: Fix pthread_attr_setaffinity_np() feature detection on Ubuntu systems

2015-02-28 Thread Jiri Olsa
On Sat, Feb 28, 2015 at 08:49:27AM +0100, Ingo Molnar wrote: SNIP 0695e57b9a6a perf tools: Factor features display code Firstly, 'factor' isn't a verb we use for code, 'factor out' is. But it's not really factoring out - it separates the code. Did this title want to say: perf

[PATCH] perf tools: Fix pthread_attr_setaffinity_np() feature detection on Ubuntu systems

2015-02-27 Thread Ingo Molnar
* Arnaldo Carvalho de Melo wrote: > Hi Ingo, > > Please consider pulling, > > - Arnaldo > > The following changes since commit 0afb1704010f60e7ae85aef0f93fc10f2d99761e: > > Merge tag 'perf-core-for-mingo' of > git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/core

[PATCH] perf tools: Fix pthread_attr_setaffinity_np() feature detection on Ubuntu systems

2015-02-27 Thread Ingo Molnar
* Arnaldo Carvalho de Melo a...@kernel.org wrote: Hi Ingo, Please consider pulling, - Arnaldo The following changes since commit 0afb1704010f60e7ae85aef0f93fc10f2d99761e: Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into