Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

2013-09-26 Thread Namhyung Kim
Hi Arnaldo, On Tue, 24 Sep 2013 14:08:42 -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Sep 24, 2013 at 05:09:21PM +0900, Namhyung Kim escreveu: >> I don't know. I just thought there's not much thing we can do for those >> files other than shutting up all warnings. > >> But if you think that'

Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

2013-09-24 Thread Arnaldo Carvalho de Melo
Em Tue, Sep 24, 2013 at 05:09:21PM +0900, Namhyung Kim escreveu: > On Mon, 23 Sep 2013 11:26:59 +0200, Borislav Petkov wrote: > > On Mon, Sep 23, 2013 at 06:15:09PM +0900, Namhyung Kim wrote: > >> I replaced them to a single -w option since all we want to do is > >> suppress any warning, right? >

Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

2013-09-24 Thread Namhyung Kim
Hi Boris, On Mon, 23 Sep 2013 11:26:59 +0200, Borislav Petkov wrote: > On Mon, Sep 23, 2013 at 06:15:09PM +0900, Namhyung Kim wrote: >> I replaced them to a single -w option since all we want to do is >> suppress any warning, right? > > Do we? And besides, -w is a big hammer as it shuts up all war

Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

2013-09-23 Thread Borislav Petkov
On Mon, Sep 23, 2013 at 06:15:09PM +0900, Namhyung Kim wrote: > I replaced them to a single -w option since all we want to do is > suppress any warning, right? Do we? And besides, -w is a big hammer as it shuts up all warnings. acme? I think special handling those files grew out of necessity to s

Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

2013-09-23 Thread Namhyung Kim
Hi Jiri, On Sat, 21 Sep 2013 14:47:14 +0200, Jiri Olsa wrote: > On Mon, Sep 16, 2013 at 11:11:16AM +0900, Namhyung Kim wrote: >> From: Namhyung Kim >> >> Some files need additional compiler flags to be built successfully. >> Cleanup Makefile by using optional per-file CFLAGS which look like >> C

Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

2013-09-23 Thread Namhyung Kim
Hi Borislav, On Sat, 21 Sep 2013 01:01:32 +0200, Borislav Petkov wrote: > On Mon, Sep 16, 2013 at 11:11:16AM +0900, Namhyung Kim wrote: >> -$(OUTPUT)util/scripting-engines/trace-event-perl.o: >> util/scripting-engines/trace-event-perl.c $(OUTPUT)PERF-CFLAGS >> -$(QUIET_CC)$(CC) -o $@ -c $(CFL

Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

2013-09-21 Thread Jiri Olsa
On Mon, Sep 16, 2013 at 11:11:16AM +0900, Namhyung Kim wrote: > From: Namhyung Kim > > Some files need additional compiler flags to be built successfully. > Cleanup Makefile by using optional per-file CFLAGS which look like > CFLAGS_dir_filename.o I like it, but I'm getting following error: $

Re: [PATCH] perf tools: Use per-file CFLAGS in Makefile

2013-09-20 Thread Borislav Petkov
On Mon, Sep 16, 2013 at 11:11:16AM +0900, Namhyung Kim wrote: > -$(OUTPUT)util/scripting-engines/trace-event-perl.o: > util/scripting-engines/trace-event-perl.c $(OUTPUT)PERF-CFLAGS > - $(QUIET_CC)$(CC) -o $@ -c $(CFLAGS) $(PERL_EMBED_CCOPTS) > -Wno-redundant-decls -Wno-strict-prototypes -Wno

[PATCH] perf tools: Use per-file CFLAGS in Makefile

2013-09-15 Thread Namhyung Kim
From: Namhyung Kim Some files need additional compiler flags to be built successfully. Cleanup Makefile by using optional per-file CFLAGS which look like CFLAGS_dir_filename.o Signed-off-by: Namhyung Kim --- tools/perf/Makefile| 128 ++--- tools/