Re: [PATCH] perf tools: return errcode in cs_etm__process_auxtrace_info

2019-03-19 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 19, 2019 at 08:55:25AM -0600, Mathieu Poirier escreveu: > On Tue, Mar 19, 2019 at 11:46:31AM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Mar 19, 2019 at 08:38:32AM -0600, Mathieu Poirier escreveu: > > > On Mon, 18 Mar 2019 at 11:15, Arnaldo Carvalho de Melo > > > wrote: > > > >

Re: [PATCH] perf tools: return errcode in cs_etm__process_auxtrace_info

2019-03-19 Thread YueHaibing
On 2019/3/19 22:55, Mathieu Poirier wrote: > On Tue, Mar 19, 2019 at 11:46:31AM -0300, Arnaldo Carvalho de Melo wrote: >> Em Tue, Mar 19, 2019 at 08:38:32AM -0600, Mathieu Poirier escreveu: >>> On Mon, 18 Mar 2019 at 11:15, Arnaldo Carvalho de Melo >>> wrote: Em Fri, Mar 15, 2019 at

Re: [PATCH] perf tools: return errcode in cs_etm__process_auxtrace_info

2019-03-19 Thread Mathieu Poirier
On Tue, Mar 19, 2019 at 11:46:31AM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Mar 19, 2019 at 08:38:32AM -0600, Mathieu Poirier escreveu: > > On Mon, 18 Mar 2019 at 11:15, Arnaldo Carvalho de Melo > > wrote: > > > > > > Em Fri, Mar 15, 2019 at 10:26:49AM +0800, Yue Haibing escreveu: > > > >

Re: [PATCH] perf tools: return errcode in cs_etm__process_auxtrace_info

2019-03-19 Thread Arnaldo Carvalho de Melo
Em Tue, Mar 19, 2019 at 08:38:32AM -0600, Mathieu Poirier escreveu: > On Mon, 18 Mar 2019 at 11:15, Arnaldo Carvalho de Melo > wrote: > > > > Em Fri, Mar 15, 2019 at 10:26:49AM +0800, Yue Haibing escreveu: > > > From: YueHaibing > > > > > > 'err' is set in err path, but it's not returned to

Re: [PATCH] perf tools: return errcode in cs_etm__process_auxtrace_info

2019-03-19 Thread Mathieu Poirier
On Mon, 18 Mar 2019 at 11:15, Arnaldo Carvalho de Melo wrote: > > Em Fri, Mar 15, 2019 at 10:26:49AM +0800, Yue Haibing escreveu: > > From: YueHaibing > > > > 'err' is set in err path, but it's not returned to callers. > > Also fix a pass zero to PTR_ERR issue. > > Next time please submit two

Re: [PATCH] perf tools: return errcode in cs_etm__process_auxtrace_info

2019-03-18 Thread Arnaldo Carvalho de Melo
Em Fri, Mar 15, 2019 at 10:26:49AM +0800, Yue Haibing escreveu: > From: YueHaibing > > 'err' is set in err path, but it's not returned to callers. > Also fix a pass zero to PTR_ERR issue. Next time please submit two patches, one for the PTR_ERR and another for not throwing away the err =

Re: [PATCH] perf tools: return errcode in cs_etm__process_auxtrace_info

2019-03-18 Thread Mathieu Poirier
Good day Yue, On Thu, 14 Mar 2019 at 20:28, Yue Haibing wrote: > > From: YueHaibing > > 'err' is set in err path, but it's not returned to callers. > Also fix a pass zero to PTR_ERR issue. > > Fixes: cd8bfd8c973e ("perf tools: Add processing of coresight metadata") > Signed-off-by: YueHaibing

[PATCH] perf tools: return errcode in cs_etm__process_auxtrace_info

2019-03-14 Thread Yue Haibing
From: YueHaibing 'err' is set in err path, but it's not returned to callers. Also fix a pass zero to PTR_ERR issue. Fixes: cd8bfd8c973e ("perf tools: Add processing of coresight metadata") Signed-off-by: YueHaibing --- tools/perf/util/cs-etm.c | 4 ++-- 1 file changed, 2 insertions(+), 2