Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-16 Thread Andi Kleen
> You mean change event-converter-for-linux-perf to add this as JSON > comments at the start of the generated files? JSON doesn't support comments unfortunately (unless they're somehow part of the data schema) -Andi

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-16 Thread Arnaldo Carvalho de Melo
Em Mon, Nov 16, 2020 at 11:12:30AM -0800, Ian Rogers escreveu: > On Mon, Nov 16, 2020 at 9:05 AM Arnaldo Carvalho de Melo > wrote: > > > Em Fri, Nov 06, 2020 at 01:21:58PM +0900, Namhyung Kim escreveu: > > > On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao > > wrote: > > > > >> Signed-off-by: Jin Yao

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-16 Thread Arnaldo Carvalho de Melo
Em Fri, Nov 06, 2020 at 01:21:58PM +0900, Namhyung Kim escreveu: > On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao wrote: > > >> Signed-off-by: Jin Yao > > > > > > It seems not applied to acme/perf/core cleanly. > > > > > > Thanks, > > > Namhyung > > > > > > > It seems the patch mail is truncated. :( >

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-16 Thread Andi Kleen
>I'd prefer if we could make a copy of these scripts into the kernel tree >along with the data files from: >https://download.01.org/perfmon/ FWIW I originally tried this to include the raw JSON files, but Ingo objected and wanted the files to be split up[1] and avoiding redundant

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-16 Thread Jin, Yao
Hi Ian, On 11/16/2020 3:25 PM, Ian Rogers wrote: No given metric group: L2_Evictions_Silent_PKI L2_Evictions_NonSilent_PKI These two metrics are available on SKX/CLX. From TMA_Metrics.csv, they are under the column 'SKX' not under the column 'SKL/KBL'. Thanks Jin Yao

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-15 Thread Andi Kleen
> Can I get ACK for this patch? > > It's mainly for fixing the perf-test issue and MEM_Parallel_Reads issue. Acked-by: Andi Kleen The JSON updates should be imho just merged automatically. Not much point in doing code review on them. If there's a problem it has to be fixed JSON upstream

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-13 Thread Jin, Yao
Hi Andi, Ian, On 11/6/2020 12:21 PM, Namhyung Kim wrote: On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao wrote: Hi Namhyung, On 11/6/2020 11:00 AM, Namhyung Kim wrote: Hi, On Wed, Nov 04, 2020 at 09:51:02AM +0800, Jin Yao wrote: - Update Skylake events to v50. - Update Skylake JSON metrics from

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-05 Thread Namhyung Kim
On Fri, Nov 6, 2020 at 12:12 PM Jin, Yao wrote: > > Hi Namhyung, > > On 11/6/2020 11:00 AM, Namhyung Kim wrote: > > Hi, > > > > On Wed, Nov 04, 2020 at 09:51:02AM +0800, Jin Yao wrote: > >> - Update Skylake events to v50. > >> - Update Skylake JSON metrics from TMAM 4.0. > >> - Fix the issue in

Re: [PATCH] perf vendor events: Update Skylake client events to v50

2020-11-05 Thread Namhyung Kim
Hi, On Wed, Nov 04, 2020 at 09:51:02AM +0800, Jin Yao wrote: > - Update Skylake events to v50. > - Update Skylake JSON metrics from TMAM 4.0. > - Fix the issue in DRAM_Parallel_Reads > - Fix the perf test warning > > Before: > > root@kbl-ppc:~# perf stat -M DRAM_Parallel_Reads -- sleep 1 >