Re: [PATCH] pfn_t: force '~' to be parsed as an unary operator

2018-10-24 Thread sebhtml
On 2018-10-24 6:43 p.m., Andrew Morton wrote: I grabbed it, and added cc:stable. But aren't we fixing this in the wrong place? That's a valid expression and if this isn't addressed in perf then we may hit a similar issue elsewhere... Right. Based on: git://git.kernel.org/pub/scm/linux/

Re: [PATCH] pfn_t: force '~' to be parsed as an unary operator

2018-10-24 Thread Andrew Morton
On Mon, 22 Oct 2018 10:13:48 -0700 Dan Williams wrote: > [ added Andrew ] > > Patch here: https://lore.kernel.org/patchwork/patch/1002234/ > > On Sun, Oct 21, 2018 at 8:00 AM Sebastien Boisvert > wrote: > > > > Tracing the event "fs_dax:dax_pmd_insert_mapping" with perf produces this > > warn

Re: [PATCH] pfn_t: force '~' to be parsed as an unary operator

2018-10-22 Thread Dan Williams
[ added Andrew ] Patch here: https://lore.kernel.org/patchwork/patch/1002234/ On Sun, Oct 21, 2018 at 8:00 AM Sebastien Boisvert wrote: > > Tracing the event "fs_dax:dax_pmd_insert_mapping" with perf produces this > warning: > [fs_dax:dax_pmd_insert_mapping] unknown op '~' > > It is printe

[PATCH] pfn_t: force '~' to be parsed as an unary operator

2018-10-21 Thread Sebastien Boisvert
Tracing the event "fs_dax:dax_pmd_insert_mapping" with perf produces this warning: [fs_dax:dax_pmd_insert_mapping] unknown op '~' It is printed in process_op (tools/lib/traceevent/event-parse.c) because '~' is parsed as a binary operator. perf reads the format of fs_dax:dax_pmd_insert_mappi