Re: [PATCH] phy: Variable "val" in function miphy_osc_is_ready() could be uninitialized

2019-02-06 Thread Kishon Vijay Abraham I
Hi Yizhuo, On 06/02/19 9:00 AM, Yizhuo wrote: > In function miphy_osc_is_ready(), local variable "val" > could be uninitalized. if function regmap_read() returns > -EINVAL. However, this value is used in if statement. > This is potentially unsafe. > > Signed-off-by: Yizhuo Can you send all

Re: [PATCH] phy: Variable "val" in function miphy_osc_is_ready() could be uninitialized

2019-02-06 Thread Patrice CHOTARD
Hi Yizhuo On 2/6/19 4:30 AM, Yizhuo wrote: > In function miphy_osc_is_ready(), local variable "val" > could be uninitalized. if function regmap_read() returns > -EINVAL. However, this value is used in if statement. > This is potentially unsafe. > > Signed-off-by: Yizhuo > --- >

[PATCH] phy: Variable "val" in function miphy_osc_is_ready() could be uninitialized

2019-02-05 Thread Yizhuo
In function miphy_osc_is_ready(), local variable "val" could be uninitalized. if function regmap_read() returns -EINVAL. However, this value is used in if statement. This is potentially unsafe. Signed-off-by: Yizhuo --- drivers/phy/st/phy-miphy28lp.c | 7 +-- 1 file changed, 5

[PATCH] phy: Variable "val" in function miphy_osc_is_ready() could be uninitialized

2019-02-05 Thread Yizhuo
In function miphy_osc_is_ready(), local variable "val" could be uninitalized. if function regmap_read() returns -EINVAL. However, this value is used in if statement. This is potentially unsafe. Signed-off-by: Yizhuo --- drivers/phy/st/phy-miphy28lp.c | 7 +-- 1 file changed, 5