Re: [PATCH] phy: fix error handling

On Mon, 4 Jul 2016, Dan Carpenter wrote: > On Mon, Jul 04, 2016 at 01:22:50PM +0530, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Monday 04 July 2016 02:38 AM, Christophe JAILLET wrote: > > > I will resubmit in the coming days. > > > > > >return PTR_ERR(phy->clk); > > > should also be up

Re: [PATCH] phy: fix error handling

On Mon, Jul 04, 2016 at 01:22:50PM +0530, Kishon Vijay Abraham I wrote: > Hi, > > On Monday 04 July 2016 02:38 AM, Christophe JAILLET wrote: > > I will resubmit in the coming days. > > > >return PTR_ERR(phy->clk); > > should also be updated. > > while at that, also fix your $subject to somet

Re: [PATCH] phy: fix error handling

Hi, On Monday 04 July 2016 02:38 AM, Christophe JAILLET wrote: > I will resubmit in the coming days. > >return PTR_ERR(phy->clk); > should also be updated. while at that, also fix your $subject to something like "phy: sun9i-usb: fix error handling" Thanks Kishon > > Best regards, > CJ >

Re: [PATCH] phy: fix error handling

I will resubmit in the coming days. return PTR_ERR(phy->clk); should also be updated. Best regards, CJ Le 03/07/2016 à 07:55, Christophe JAILLET a écrit : This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is expected here. Signed-off-by: Christophe JAILLET --- drivers/p

Re: [PATCH] phy: fix error handling

On Sun, Jul 03, 2016 at 07:55:32AM +0200, Christophe JAILLET wrote: > This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is > expected here. > > Signed-off-by: Christophe JAILLET Acked-by: Maxime Ripard Thanks! Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel an

[PATCH] phy: fix error handling

This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is expected here. Signed-off-by: Christophe JAILLET --- drivers/phy/phy-sun9i-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/phy/phy-sun9i-usb.c b/drivers/phy/phy-sun9i-usb.c index ac4f31a..ff99