Re: [PATCH] phy: inno-usb2-phy: fix off-by-one comparison on port number

2018-10-09 Thread Shawn Guo
On Tue, Oct 9, 2018 at 6:24 AM Colin King wrote: > > From: Colin Ian King > > Currently the range check on the port index is off-by-one and a potential > out of bounds write can occur on priv->ports[i]. Fix this by checking the > maximum port using >= INNO_PHY_PORT_NUM rather than > INNO_PHY_PORT

[PATCH] phy: inno-usb2-phy: fix off-by-one comparison on port number

2018-10-08 Thread Colin King
From: Colin Ian King Currently the range check on the port index is off-by-one and a potential out of bounds write can occur on priv->ports[i]. Fix this by checking the maximum port using >= INNO_PHY_PORT_NUM rather than > INNO_PHY_PORT_NUM. Detected by CoverityScan, CID#1466118 ("Out-of-bounds