Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-17 Thread Florian Fainelli
On 11/17/2020 5:45 AM, Andrew Lunn wrote: >>> Do you have the Marvell PHY driver either built-in or available as a >>> module? I suspect the problem is you don't. You will need the Marvell >>> PHY driver to correctly drive the PHY, you can't rely on the fallback >>> driver for SFPs. >> Correct.

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-17 Thread Andrew Lunn
> > Do you have the Marvell PHY driver either built-in or available as a > > module? I suspect the problem is you don't. You will need the Marvell > > PHY driver to correctly drive the PHY, you can't rely on the fallback > > driver for SFPs. > Correct. I was using the generic driver and that does

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-17 Thread Bjarni Jonasson
Russell King - ARM Linux admin writes: > On Wed, Nov 11, 2020 at 09:52:18AM +0100, Bjarni Jonasson wrote: >> >> Russell King - ARM Linux admin writes: >> >> > On Tue, Nov 10, 2020 at 03:16:34PM +0100, Bjarni Jonasson wrote: >> >> >> >> Russell King - ARM Linux admin writes: >> >> >> >> > On

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-15 Thread Russell King - ARM Linux admin
On Wed, Nov 11, 2020 at 09:52:18AM +0100, Bjarni Jonasson wrote: > > Russell King - ARM Linux admin writes: > > > On Tue, Nov 10, 2020 at 03:16:34PM +0100, Bjarni Jonasson wrote: > >> > >> Russell King - ARM Linux admin writes: > >> > >> > On Tue, Nov 10, 2020 at 11:06:42AM +0100, Bjarni

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-11 Thread Bjarni Jonasson
Russell King - ARM Linux admin writes: > On Tue, Nov 10, 2020 at 03:16:34PM +0100, Bjarni Jonasson wrote: >> >> Russell King - ARM Linux admin writes: >> >> > On Tue, Nov 10, 2020 at 11:06:42AM +0100, Bjarni Jonasson wrote: >> >> There is an issue with the current phylink driver and CuSFPs

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-10 Thread Russell King - ARM Linux admin
On Tue, Nov 10, 2020 at 03:16:34PM +0100, Bjarni Jonasson wrote: > > Russell King - ARM Linux admin writes: > > > On Tue, Nov 10, 2020 at 11:06:42AM +0100, Bjarni Jonasson wrote: > >> There is an issue with the current phylink driver and CuSFPs which > >> results in a callback to the phylink

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-10 Thread Bjarni Jonasson
Russell King - ARM Linux admin writes: > On Tue, Nov 10, 2020 at 11:06:42AM +0100, Bjarni Jonasson wrote: >> There is an issue with the current phylink driver and CuSFPs which >> results in a callback to the phylink validate function without any >> advertisement capabilities. The workaround

Re: [PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-10 Thread Russell King - ARM Linux admin
On Tue, Nov 10, 2020 at 11:06:42AM +0100, Bjarni Jonasson wrote: > There is an issue with the current phylink driver and CuSFPs which > results in a callback to the phylink validate function without any > advertisement capabilities. The workaround (in this changeset) > is to assign capabilities

[PATCH] phy: phylink: Fix CuSFP issue in phylink

2020-11-10 Thread Bjarni Jonasson
There is an issue with the current phylink driver and CuSFPs which results in a callback to the phylink validate function without any advertisement capabilities. The workaround (in this changeset) is to assign capabilities if a 1000baseT SFP is identified. Signed-off-by: Bjarni Jonasson ---