Re: [PATCH] phy: qcom: qmp: Add SDM845 PCIe QMP PHY support

2019-03-29 Thread Marc Gonzalez
On 22/03/2019 14:42, Marc Gonzalez wrote: > On 26/02/2019 07:59, Bjorn Andersson wrote: > >> @@ -1384,6 +1536,11 @@ static int qcom_qmp_phy_init(struct phy *phy) >> >> qcom_qmp_phy_configure(pcs, cfg->regs, cfg->pcs_tbl, cfg->pcs_tbl_num); >> >> +if (cfg->pcs_misc_tbl) { >> +

Re: [PATCH] phy: qcom: qmp: Add SDM845 PCIe QMP PHY support

2019-03-26 Thread Rob Herring
On Mon, Feb 25, 2019 at 10:59:19PM -0800, Bjorn Andersson wrote: > qcom_qmp_phy_init() is extended to support the additional register > writes needed in PCS MISC and the appropriate sequences and resources > are defined for SDM845. > > Signed-off-by: Bjorn Andersson > --- >

Re: [PATCH] phy: qcom: qmp: Add SDM845 PCIe QMP PHY support

2019-03-22 Thread Evan Green
On Mon, Feb 25, 2019 at 10:58 PM Bjorn Andersson wrote: > > qcom_qmp_phy_init() is extended to support the additional register > writes needed in PCS MISC and the appropriate sequences and resources > are defined for SDM845. > > Signed-off-by: Bjorn Andersson > --- How badly does this conflict

Re: [PATCH] phy: qcom: qmp: Add SDM845 PCIe QMP PHY support

2019-03-22 Thread Marc Gonzalez
On 26/02/2019 07:59, Bjorn Andersson wrote: > @@ -1384,6 +1536,11 @@ static int qcom_qmp_phy_init(struct phy *phy) > > qcom_qmp_phy_configure(pcs, cfg->regs, cfg->pcs_tbl, cfg->pcs_tbl_num); > > + if (cfg->pcs_misc_tbl) { > + qcom_qmp_phy_configure(pcs_misc, cfg->regs,

Re: [PATCH] phy: qcom: qmp: Add SDM845 PCIe QMP PHY support

2019-02-27 Thread Bjorn Andersson
On Wed 27 Feb 01:27 PST 2019, Marc Gonzalez wrote: > On 26/02/2019 07:59, Bjorn Andersson wrote: > > > qcom_qmp_phy_init() is extended to support the additional register > > writes needed in PCS MISC and the appropriate sequences and resources > > are defined for SDM845. > > > > Signed-off-by:

Re: [PATCH] phy: qcom: qmp: Add SDM845 PCIe QMP PHY support

2019-02-27 Thread Marc Gonzalez
On 26/02/2019 07:59, Bjorn Andersson wrote: > +static const unsigned int sdm845_pciephy_regs_layout[] = { > + [QPHY_START_CTRL] = 0x08, > + [QPHY_PCS_READY_STATUS] = 0x174, > +}; > + Just use pciephy_regs_layout? > +static const struct qmp_phy_cfg

Re: [PATCH] phy: qcom: qmp: Add SDM845 PCIe QMP PHY support

2019-02-27 Thread Marc Gonzalez
On 26/02/2019 07:59, Bjorn Andersson wrote: > qcom_qmp_phy_init() is extended to support the additional register > writes needed in PCS MISC and the appropriate sequences and resources > are defined for SDM845. > > Signed-off-by: Bjorn Andersson > --- >

[PATCH] phy: qcom: qmp: Add SDM845 PCIe QMP PHY support

2019-02-25 Thread Bjorn Andersson
qcom_qmp_phy_init() is extended to support the additional register writes needed in PCS MISC and the appropriate sequences and resources are defined for SDM845. Signed-off-by: Bjorn Andersson --- .../devicetree/bindings/phy/qcom-qmp-phy.txt | 7 + drivers/phy/qualcomm/phy-qcom-qmp.c