RE: [PATCH] phy: renesas: rcar-gen2: Fix memory leak at error paths

2019-02-27 Thread Julia Lawall
On Wed, 27 Feb 2019, Yoshihiro Shimoda wrote: > Hello, > > > From: Julia Lawall, Sent: Wednesday, February 27, 2019 5:25 PM > > > > On Wed, 27 Feb 2019, Yoshihiro Shimoda wrote: > > > > > This patch fixes memory leak at error paths of the probe function. > > > In for_each_child_of_node, if the

Re: [PATCH] phy: renesas: rcar-gen2: Fix memory leak at error paths

2019-02-27 Thread Geert Uytterhoeven
Hi Shimoda-san, On Wed, Feb 27, 2019 at 9:53 AM Yoshihiro Shimoda wrote: > > From: Julia Lawall, Sent: Wednesday, February 27, 2019 5:25 PM > > On Wed, 27 Feb 2019, Yoshihiro Shimoda wrote: > > > This patch fixes memory leak at error paths of the probe function. > > > In for_each_child_of_node, i

Re: [PATCH] phy: renesas: rcar-gen2: Fix memory leak at error paths

2019-02-27 Thread Geert Uytterhoeven
Hi Shimoda-san, On Wed, Feb 27, 2019 at 8:00 AM Yoshihiro Shimoda wrote: > This patch fixes memory leak at error paths of the probe function. > In for_each_child_of_node, if the loop returns, the driver should > call of_put_node() before returns. > > Reported-by: Julia Lawall > Fixes: 1233f59f74

RE: [PATCH] phy: renesas: rcar-gen2: Fix memory leak at error paths

2019-02-27 Thread Yoshihiro Shimoda
Hello, > From: Julia Lawall, Sent: Wednesday, February 27, 2019 5:25 PM > > On Wed, 27 Feb 2019, Yoshihiro Shimoda wrote: > > > This patch fixes memory leak at error paths of the probe function. > > In for_each_child_of_node, if the loop returns, the driver should > > call of_put_node() before r

Re: [PATCH] phy: renesas: rcar-gen2: Fix memory leak at error paths

2019-02-27 Thread Julia Lawall
On Wed, 27 Feb 2019, Yoshihiro Shimoda wrote: > This patch fixes memory leak at error paths of the probe function. > In for_each_child_of_node, if the loop returns, the driver should > call of_put_node() before returns. > > Reported-by: Julia Lawall > Fixes: 1233f59f745 ("phy: Renesas R-Car Ge

[PATCH] phy: renesas: rcar-gen2: Fix memory leak at error paths

2019-02-26 Thread Yoshihiro Shimoda
This patch fixes memory leak at error paths of the probe function. In for_each_child_of_node, if the loop returns, the driver should call of_put_node() before returns. Reported-by: Julia Lawall Fixes: 1233f59f745 ("phy: Renesas R-Car Gen2 PHY driver") Signed-off-by: Yoshihiro Shimoda --- driver