Re: [PATCH] phy: tegra-xusb: add pinctrl dependency

2016-05-03 Thread Arnd Bergmann
On Tuesday 03 May 2016 18:07:08 Thierry Reding wrote: > Wouldn't that be more of a case for a select dependency? I'm thinking > something like the below (untested, yet). > I usually prefer 'depends on' in a case like this, but it doesn't make a huge difference. If we end up using 'select' here, w

Re: [PATCH] phy: tegra-xusb: add pinctrl dependency

2016-05-03 Thread Thierry Reding
On Tue, May 03, 2016 at 05:24:51PM +0200, Arnd Bergmann wrote: > The newly added tegra xusb phy driver fails to link when CONFIG_PINCTRL > is disabled, since that also leaves out the legacy probe function: > > ERROR: "tegra_xusb_padctl_legacy_probe" [drivers/phy/tegra/phy-tegra-xusb.ko] > undefin

[PATCH] phy: tegra-xusb: add pinctrl dependency

2016-05-03 Thread Arnd Bergmann
The newly added tegra xusb phy driver fails to link when CONFIG_PINCTRL is disabled, since that also leaves out the legacy probe function: ERROR: "tegra_xusb_padctl_legacy_probe" [drivers/phy/tegra/phy-tegra-xusb.ko] undefined! This adds a Kconfig dependency for it, depending on both PINCTRL_TEG