Re: [PATCH] pinctrl: bcm2835: constify gpio_chip structure

2017-08-02 Thread Linus Walleij
On Tue, Jul 11, 2017 at 8:03 PM, Gustavo A. R. Silva wrote: > This structure is only used to copy into other structure, so declare > it as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ >

Re: [PATCH] pinctrl: bcm2835: constify gpio_chip structure

2017-07-16 Thread Gustavo A. R. Silva
On 07/12/2017 02:13 PM, Eric Anholt wrote: "Gustavo A. R. Silva" writes: This structure is only used to copy into other structure, so declare it as const. This issue was detected using Coccinelle and the following semantic patch: Acked-by: Eric Anholt Thank you, Eric --- drivers/pin

Re: [PATCH] pinctrl: bcm2835: constify gpio_chip structure

2017-07-12 Thread Eric Anholt
"Gustavo A. R. Silva" writes: > This structure is only used to copy into other structure, so declare > it as const. > > This issue was detected using Coccinelle and the following semantic patch: Acked-by: Eric Anholt > --- > drivers/pinctrl/bcm/pinctrl-bcm2835.c | 2 +- > 1 file changed, 1 in

[PATCH] pinctrl: bcm2835: constify gpio_chip structure

2017-07-11 Thread Gustavo A. R. Silva
This structure is only used to copy into other structure, so declare it as const. This issue was detected using Coccinelle and the following semantic patch: @r disable optional_qualifier@ identifier i; position p; @@ static struct gpio_chip i@p = { ... }; @ok@ identifier r.i; expression e; posit