Re: [PATCH] pinctrl: meson: fix pull enable register calculation

2018-11-19 Thread Linus Walleij
On Tue, Nov 13, 2018 at 11:55 AM Jerome Brunet wrote: > We just changed the code so we apply bias disable on the correct > register but forgot to align the register calculation. The result > is that we apply the change on the correct register, but possibly > at the incorrect offset/bit > > This w

Re: [PATCH] pinctrl: meson: fix pull enable register calculation

2018-11-13 Thread Neil Armstrong
On 13/11/2018 11:55, Jerome Brunet wrote: > We just changed the code so we apply bias disable on the correct > register but forgot to align the register calculation. The result > is that we apply the change on the correct register, but possibly > at the incorrect offset/bit > > This went undetecte

[PATCH] pinctrl: meson: fix pull enable register calculation

2018-11-13 Thread Jerome Brunet
We just changed the code so we apply bias disable on the correct register but forgot to align the register calculation. The result is that we apply the change on the correct register, but possibly at the incorrect offset/bit This went undetected because offsets tends to be the same between REG_PUL