Re: [PATCH] pinctrl: nsp: Set irq handler based on trig type

On Tue, 2020-06-30 at 15:26 -0700, Ray Jui wrote: > - u32 trigger_type; > > > > - trigger_type = irq_get_trigger_type(d->irq); > > - if (trigger_type & (IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING)) > > - nsp_set_bit(chip, REG, NSP_GPIO_EVENT, gpio, val); > > + nsp_set_bit(ch

Re: [PATCH] pinctrl: nsp: Set irq handler based on trig type

Hi Mark, On 6/30/2020 1:47 PM, Mark Tomlinson wrote: > Rather than always using handle_simple_irq() as the gpio_irq_chip > handler, set a more appropriate handler based on the IRQ trigger type > requested. This is important for level triggered interrupts which need > to be masked during handling.

[PATCH] pinctrl: nsp: Set irq handler based on trig type

Rather than always using handle_simple_irq() as the gpio_irq_chip handler, set a more appropriate handler based on the IRQ trigger type requested. This is important for level triggered interrupts which need to be masked during handling. Also, always acknowledge the interrupt regardless of whether i