Re: [PATCH] pinctrl: return real error codes when pinctrl is not included

2013-02-24 Thread Heiko Stübner
Am Sonntag, 24. Februar 2013, 23:42:32 schrieb Linus Walleij: > On Sun, Feb 24, 2013 at 11:34 PM, Heiko Stübner wrote: > > [Me] > > > >> This make me suspect that you have this ugly patch in some > >> private repo and I will be seeing it again and again :-( > > > > All my s3c24xx work is done is

Re: [PATCH] pinctrl: return real error codes when pinctrl is not included

2013-02-24 Thread Heiko Stübner
Am Sonntag, 24. Februar 2013, 01:40:58 schrieb Linus Walleij: > On Sat, Feb 23, 2013 at 6:56 PM, Heiko Stübner wrote: > > Currently the fallback functions when pinctrl is not being built do > > return either NULL or 0, either no pinctrl handle or no error, > > making them fail silently. > > > > A

Re: [PATCH] pinctrl: return real error codes when pinctrl is not included

2013-02-24 Thread Linus Walleij
On Sun, Feb 24, 2013 at 11:34 PM, Heiko Stübner wrote: > [Me] >> This make me suspect that you have this ugly patch in some >> private repo and I will be seeing it again and again :-( > > All my s3c24xx work is done is my spare time, so I have to confess I came up > with this "ugly patch" all by

Re: [PATCH] pinctrl: return real error codes when pinctrl is not included

2013-02-23 Thread Linus Walleij
On Sat, Feb 23, 2013 at 6:56 PM, Heiko Stübner wrote: > Currently the fallback functions when pinctrl is not being built do > return either NULL or 0, either no pinctrl handle or no error, > making them fail silently. > > All drivers using pinctrl do only test for error conditions, which > made f

[PATCH] pinctrl: return real error codes when pinctrl is not included

2013-02-23 Thread Heiko Stübner
Currently the fallback functions when pinctrl is not being built do return either NULL or 0, either no pinctrl handle or no error, making them fail silently. All drivers using pinctrl do only test for error conditions, which made for example the i2c-s3c2410 driver fail on a devicetree based machin