Re: [PATCH] pinctrl: sirf: Add missing put_device() call in sirfsoc_gpio_probe()

2020-06-02 Thread yukuai (C)
On 2020/6/3 2:56, Markus Elfring wrote: in sirfsoc_gpio_probe(), if of_find_device_by_node() succeed, put_device() is missing in the error handling patch. How do you think about another wording variant? A coccicheck run provided information like the following.

Re: [PATCH] pinctrl: sirf: Add missing put_device() call in sirfsoc_gpio_probe()

2020-06-02 Thread Markus Elfring
> in sirfsoc_gpio_probe(), if of_find_device_by_node() succeed, > put_device() is missing in the error handling patch. How do you think about another wording variant? A coccicheck run provided information like the following. drivers/pinctrl/sirf/pinctrl-sirf.c:798:2-8: ERROR: missing