Re: [PATCH] pinctrl:intel: Retain HOSTSW_OWN for requested gpio pin

2019-04-08 Thread Andy Shevchenko
On Mon, Apr 08, 2019 at 10:41:06AM +0300, Mika Westerberg wrote: > On Mon, Apr 08, 2019 at 12:21:03PM +0800, Chris Chiu wrote: > > +static void static u32 (see below why) > > +intel_gpio_update_pad_mode(void __iomem *hostown, u32 mask, u32 value) > > +{ > > + u32 curr = readl(hostown); > > +

Re: [PATCH] pinctrl:intel: Retain HOSTSW_OWN for requested gpio pin

2019-04-08 Thread Mika Westerberg
On Mon, Apr 08, 2019 at 12:21:03PM +0800, Chris Chiu wrote: > +static void > +intel_gpio_update_pad_mode(void __iomem *hostown, u32 mask, u32 value) > +{ > + u32 curr = readl(hostown); > + u32 updated = (curr & ~mask) | (value & mask); I think here we should first complain if the expected

[PATCH] pinctrl:intel: Retain HOSTSW_OWN for requested gpio pin

2019-04-07 Thread Chris Chiu
The touchpad of the ASUS laptops E403NA, X540NA, X541NA are not responsive after suspend/resume. The following error message shows after resume. i2c_hid i2c-ELAN1200:00: failed to reset device. On these laptops, the touchpad interrupt is connected via a GPIO pin which is controlled by Intel pinct