Re: [PATCH] pipe: fix potential inode leak in create_pipe_files()

2020-10-29 Thread Al Viro
On Wed, Oct 28, 2020 at 11:03:52AM +0800, Zhiqiang Liu wrote: > > In create_pipe_files(), if alloc_file_clone() fails, we will call > put_pipe_info to release pipe, and call fput() to release f. > However, we donot call iput() to free inode. Huh? Have you actually tried to trigger that failure

Re: [PATCH] pipe: fix potential inode leak in create_pipe_files()

2020-10-28 Thread Zhiqiang Liu
On 2020/10/28 11:54, Al Viro wrote: > On Wed, Oct 28, 2020 at 11:03:52AM +0800, Zhiqiang Liu wrote: >> >> In create_pipe_files(), if alloc_file_clone() fails, we will call >> put_pipe_info to release pipe, and call fput() to release f. >> However, we donot call iput() to free inode. > > Huh?

[PATCH] pipe: fix potential inode leak in create_pipe_files()

2020-10-28 Thread Zhiqiang Liu
In create_pipe_files(), if alloc_file_clone() fails, we will call put_pipe_info to release pipe, and call fput() to release f. However, we donot call iput() to free inode. Signed-off-by: Zhiqiang Liu Signed-off-by: Feilong Lin --- fs/pipe.c | 1 + 1 file changed, 1 insertion(+) diff --git