Hi!
> > > Because I need to understand why you believe that device name for
> > > kbd_backlight matters, and having wilco::kbd_backlight is a bad idea,
> > > but, for example, having max77650::kbd_backlight is perfectly fine if
> > > somebody decided to wire it in this way.
> >
> >
On Thu, Apr 4, 2019 at 1:11 PM Pavel Machek wrote:
>
> On Thu 2019-04-04 13:07:39, Dmitry Torokhov wrote:
> > On Thu, Apr 4, 2019 at 12:23 PM Pavel Machek wrote:
> > >
> > > Hi!
> > >
> > > > > > > Yeah, well, we not let the cros_kbd_led_backlight.c use
> > > > > > > chromeos:: in
> > > > > > >
On Thu 2019-04-04 13:07:39, Dmitry Torokhov wrote:
> On Thu, Apr 4, 2019 at 12:23 PM Pavel Machek wrote:
> >
> > Hi!
> >
> > > > > > Yeah, well, we not let the cros_kbd_led_backlight.c use chromeos::
> > > > > > in
> > > > > > the first place. But it happened. We want all backlights for the
> >
On Thu, Apr 4, 2019 at 12:23 PM Pavel Machek wrote:
>
> Hi!
>
> > > > > Yeah, well, we not let the cros_kbd_led_backlight.c use chromeos:: in
> > > > > the first place. But it happened. We want all backlights for the
> > > > > system keyboard to use common name, and "chromeos" is not really
> > >
Hi!
> > > > Yeah, well, we not let the cros_kbd_led_backlight.c use chromeos:: in
> > > > the first place. But it happened. We want all backlights for the
> > > > system keyboard to use common name, and "chromeos" is not really
> > > > suitable for that. "platform" is.
> > >
> > > Pavel, who
On Thu, Apr 4, 2019 at 12:03 PM Pavel Machek wrote:
>
> On Thu 2019-04-04 09:13:27, Dmitry Torokhov wrote:
> > On Thu, Apr 4, 2019 at 4:24 AM Pavel Machek wrote:
> > >
> > > On Mon 2019-03-11 09:29:06, Nick Crews wrote:
> > > > Thanks for looking this over. I will fix most of your concerns, but
On Thu 2019-04-04 09:13:27, Dmitry Torokhov wrote:
> On Thu, Apr 4, 2019 at 4:24 AM Pavel Machek wrote:
> >
> > On Mon 2019-03-11 09:29:06, Nick Crews wrote:
> > > Thanks for looking this over. I will fix most of your concerns, but
> > > have one question.
> > >
> > > On Fri, Mar 8, 2019 at 2:08
On Thu, Apr 4, 2019 at 4:24 AM Pavel Machek wrote:
>
> On Mon 2019-03-11 09:29:06, Nick Crews wrote:
> > Thanks for looking this over. I will fix most of your concerns, but
> > have one question.
> >
> > On Fri, Mar 8, 2019 at 2:08 PM Pavel Machek wrote:
> > >
> > > On Fri 2019-03-08 13:38:02,
On Thu, Apr 4, 2019 at 5:24 AM Pavel Machek wrote:
>
> On Mon 2019-03-11 09:29:06, Nick Crews wrote:
> > Thanks for looking this over. I will fix most of your concerns, but
> > have one question.
> >
> > On Fri, Mar 8, 2019 at 2:08 PM Pavel Machek wrote:
> > >
> > > On Fri 2019-03-08 13:38:02,
On Mon 2019-03-11 09:29:06, Nick Crews wrote:
> Thanks for looking this over. I will fix most of your concerns, but
> have one question.
>
> On Fri, Mar 8, 2019 at 2:08 PM Pavel Machek wrote:
> >
> > On Fri 2019-03-08 13:38:02, Nick Crews wrote:
> > > This patch is meant to be applied on top of
> > > Some Wilco devices do not support a keyboard backlight. This
> > > is checked in probe(), and in this case the sysfs entry will
> > > not appear, and everything will behave normally.
> >
> > It would be even better if we did not register platform device if EC
> > does not support backlight.
On Mon 2019-03-11 09:36:20, Nick Crews wrote:
> On Fri, Mar 8, 2019 at 3:13 PM Pavel Machek wrote:
> >
> > Hi!
> >
> > > > This patch is meant to be applied on top of the for-next
> > > > branch of the platform/chrome repository, as it uses some of
> > > > the code staged there.
> > > >
> > > >
Thanks for looking this over. I will fix most of your concerns, but
have one question.
On Fri, Mar 8, 2019 at 2:08 PM Pavel Machek wrote:
>
> On Fri 2019-03-08 13:38:02, Nick Crews wrote:
> > This patch is meant to be applied on top of the for-next
> > branch of the platform/chrome repository,
Hi!
> > This patch is meant to be applied on top of the for-next
> > branch of the platform/chrome repository, as it uses some of
> > the code staged there.
> >
> > The EC is in charge of controlling the keyboard backlight on
> > the Wilco platform. We expose a standard LED class device at
> >
On Fri, Mar 8, 2019 at 12:41 PM Nick Crews wrote:
>
> This patch is meant to be applied on top of the for-next
> branch of the platform/chrome repository, as it uses some of
> the code staged there.
>
> The EC is in charge of controlling the keyboard backlight on
> the Wilco platform. We expose a
On Fri 2019-03-08 13:38:02, Nick Crews wrote:
> This patch is meant to be applied on top of the for-next
> branch of the platform/chrome repository, as it uses some of
> the code staged there.
>
> The EC is in charge of controlling the keyboard backlight on
> the Wilco platform. We expose a
This patch is meant to be applied on top of the for-next
branch of the platform/chrome repository, as it uses some of
the code staged there.
The EC is in charge of controlling the keyboard backlight on
the Wilco platform. We expose a standard LED class device at
17 matches
Mail list logo
