Re: [PATCH] platform/chrome: Add pstore platform_device

2013-11-25 Thread Olof Johansson
On Mon, Nov 25, 2013 at 12:04 PM, Randy Dunlap wrote: > On 11/25/13 11:37, Olof Johansson wrote: >> Add the ramoops pstore device so that we get logs of panics across reboots. >> >> Signed-off-by: Olof Johansson >> --- >> >> drivers/platform/chrome/Kconfig | 14 + >> drivers/platf

Re: [PATCH] platform/chrome: Add pstore platform_device

2013-11-25 Thread Randy Dunlap
On 11/25/13 11:37, Olof Johansson wrote: > Add the ramoops pstore device so that we get logs of panics across reboots. > > Signed-off-by: Olof Johansson > --- > > drivers/platform/chrome/Kconfig | 14 + > drivers/platform/chrome/Makefile | 1 + > drivers/platform/chrom

Re: [PATCH] platform/chrome: Add pstore platform_device

2013-11-25 Thread Felipe Balbi
Hi, On Mon, Nov 25, 2013 at 11:59:50AM -0800, Olof Johansson wrote: > >> +static int __init chromeos_pstore_init(void) > >> +{ > >> + if (dmi_check_system(chromeos_pstore_dmi_table)) > > > > is this check really necessary ? I would assume that your probe would > > only be called if the device

Re: [PATCH] platform/chrome: Add pstore platform_device

2013-11-25 Thread Olof Johansson
On Mon, Nov 25, 2013 at 11:52 AM, Felipe Balbi wrote: > Hi, > > On Mon, Nov 25, 2013 at 11:37:06AM -0800, Olof Johansson wrote: >> Add the ramoops pstore device so that we get logs of panics across reboots. >> >> Signed-off-by: Olof Johansson >> --- >> >> drivers/platform/chrome/Kconfig

Re: [PATCH] platform/chrome: Add pstore platform_device

2013-11-25 Thread Felipe Balbi
Hi, On Mon, Nov 25, 2013 at 11:37:06AM -0800, Olof Johansson wrote: > Add the ramoops pstore device so that we get logs of panics across reboots. > > Signed-off-by: Olof Johansson > --- > > drivers/platform/chrome/Kconfig | 14 + > drivers/platform/chrome/Makefile | 1

[PATCH] platform/chrome: Add pstore platform_device

2013-11-25 Thread Olof Johansson
Add the ramoops pstore device so that we get logs of panics across reboots. Signed-off-by: Olof Johansson --- drivers/platform/chrome/Kconfig | 14 + drivers/platform/chrome/Makefile | 1 + drivers/platform/chrome/chromeos_pstore.c | 101 ++