Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-25 Thread Andy Shevchenko
On Tue, Apr 25, 2017 at 12:35 AM, Maarten Maathuis wrote: > Tested on HP Elite X2 1012 G1. > Matches event report of Lenovo Helix 2 > (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html). > > V2: Fix indent and add sign-off > V3: Missing whitespace correction Slightly modified (*) version

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-24 Thread AceLan Kao
In the beginning, we just need the power button function, so I didn't implement all the keys to the driver. And we didn't get any further requirement from the following projects we were working on, so I'm not aware that there are machines other than Dell using this driver. I'll try filling up all

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-24 Thread Maarten Maathuis
On Tue, Apr 25, 2017 at 4:43 AM, AceLan Kao wrote: > According the spec. I have, the values are correct. > Please merge it, thanks. > Is there a reason the whole spec isn't implemented? Is it under NDA? > 2017-04-25 5:41 GMT+08:00 Maarten Maathuis : >> On Mon, Apr 24, 2017 at 11:37 PM, Andy Shev

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-24 Thread AceLan Kao
According the spec. I have, the values are correct. Please merge it, thanks. 2017-04-25 5:41 GMT+08:00 Maarten Maathuis : > On Mon, Apr 24, 2017 at 11:37 PM, Andy Shevchenko > wrote: >> On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis >> wrote: >>> Tested on HP Elite X2 1012 G1. >>> Matches e

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-24 Thread Maarten Maathuis
On Mon, Apr 24, 2017 at 11:37 PM, Andy Shevchenko wrote: > On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis > wrote: >> Tested on HP Elite X2 1012 G1. >> Matches event report of Lenovo Helix 2 >> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html). >> > > Much better! > >> V2: Fix ind

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-24 Thread Andy Shevchenko
On Tue, Apr 25, 2017 at 12:29 AM, Maarten Maathuis wrote: > Tested on HP Elite X2 1012 G1. > Matches event report of Lenovo Helix 2 > (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html). > Much better! > V2: Fix indent and add sign-off Usually this line goes after --- (body delimiter).

[PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-24 Thread Maarten Maathuis
Tested on HP Elite X2 1012 G1. Matches event report of Lenovo Helix 2 (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html). V2: Fix indent and add sign-off V3: Missing whitespace correction Signed-off-by: Maarten Maathuis --- drivers/platform/x86/intel-vbtn.c | 4 1 file changed, 4

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-24 Thread Maarten Maathuis
On Mon, Apr 24, 2017 at 10:55 PM, Andy Shevchenko wrote: > On Mon, Apr 24, 2017 at 11:47 PM, Maarten Maathuis > wrote: >> Tested on HP Elite X2 1012 G1. >> Matches event report of Lenovo Helix 2 >> (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html). > > Thanks for the patch. > > A bit

[PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-24 Thread Maarten Maathuis
Tested on HP Elite X2 1012 G1. Matches event report of Lenovo Helix 2 (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html). V2: Fix indent and add sign-off Signed-off-by: Maarten Maathuis --- drivers/platform/x86/intel-vbtn.c | 4 1 file changed, 4 insertions(+) diff --git a/drive

Re: [PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-24 Thread Andy Shevchenko
On Mon, Apr 24, 2017 at 11:47 PM, Maarten Maathuis wrote: > Tested on HP Elite X2 1012 G1. > Matches event report of Lenovo Helix 2 > (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html). Thanks for the patch. A bit of work still required. According to Submitting Patches document [1] we

[PATCH] platform/x86/intel-vbtn: add volume up and down

2017-04-24 Thread Maarten Maathuis
Tested on HP Elite X2 1012 G1. Matches event report of Lenovo Helix 2 (https://www.spinics.net/lists/ibm-acpi-devel/msg03982.html). --- drivers/platform/x86/intel-vbtn.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/intel-vbtn.c b/drivers/platfor