Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-24 Thread Andy Shevchenko
On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli wrote: > From: Guenter Roeck > > This patch adds support for the IMS (now Zodiac Inflight Innovations) > SCU Generation 1/2/3 platform driver. This driver registers all the > on-module peripherals:

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-24 Thread Andy Shevchenko
On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli wrote: > From: Guenter Roeck > > This patch adds support for the IMS (now Zodiac Inflight Innovations) > SCU Generation 1/2/3 platform driver. This driver registers all the > on-module peripherals: Ethernet switches (Broadcom or Marvell), I2C to

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-24 Thread Andy Shevchenko
On Tue, Jan 24, 2017 at 10:07 PM, Florian Fainelli wrote: > On 01/24/2017 11:39 AM, Andy Shevchenko wrote: > + { /* bit 5 */ > +.name = "SD6:a:error", > +.gpio = SCU_SD_ERROR_6_GPIO, > +.active_low = 1,

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-24 Thread Andy Shevchenko
On Tue, Jan 24, 2017 at 10:07 PM, Florian Fainelli wrote: > On 01/24/2017 11:39 AM, Andy Shevchenko wrote: > + { /* bit 5 */ > +.name = "SD6:a:error", > +.gpio = SCU_SD_ERROR_6_GPIO, > +.active_low = 1, > +

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-24 Thread Florian Fainelli
On 01/24/2017 11:39 AM, Andy Shevchenko wrote: >> Are you concerned with storage, or what motivates the preference for >> bitfields vs. bools? > > Just matter of style. Up to you. > + { /* bit 5 */ +.name = "SD6:a:error", +.gpio =

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-24 Thread Florian Fainelli
On 01/24/2017 11:39 AM, Andy Shevchenko wrote: >> Are you concerned with storage, or what motivates the preference for >> bitfields vs. bools? > > Just matter of style. Up to you. > + { /* bit 5 */ +.name = "SD6:a:error", +.gpio =

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-24 Thread Andy Shevchenko
On Sat, Jan 14, 2017 at 1:15 AM, Florian Fainelli wrote: > On 01/13/2017 08:38 AM, Andy Shevchenko wrote: >> On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli >> wrote: >>> This patch adds support for the IMS (now Zodiac Inflight Innovations) >>> SCU

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-24 Thread Andy Shevchenko
On Sat, Jan 14, 2017 at 1:15 AM, Florian Fainelli wrote: > On 01/13/2017 08:38 AM, Andy Shevchenko wrote: >> On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli >> wrote: >>> This patch adds support for the IMS (now Zodiac Inflight Innovations) >>> SCU Generation 1/2/3 platform driver. This

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-24 Thread Florian Fainelli
On 01/13/2017 08:38 AM, Andy Shevchenko wrote: > On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli > wrote: >> From: Guenter Roeck >> >> This patch adds support for the IMS (now Zodiac Inflight Innovations) >> SCU Generation 1/2/3 platform driver. This

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-24 Thread Florian Fainelli
On 01/13/2017 08:38 AM, Andy Shevchenko wrote: > On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli > wrote: >> From: Guenter Roeck >> >> This patch adds support for the IMS (now Zodiac Inflight Innovations) >> SCU Generation 1/2/3 platform driver. This driver registers all the >> on-module

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread Guenter Roeck
On 01/13/2017 03:15 PM, Florian Fainelli wrote: On 01/13/2017 08:38 AM, Andy Shevchenko wrote: On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli wrote: From: Guenter Roeck This patch adds support for the IMS (now Zodiac Inflight Innovations) SCU

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread Guenter Roeck
On 01/13/2017 03:15 PM, Florian Fainelli wrote: On 01/13/2017 08:38 AM, Andy Shevchenko wrote: On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli wrote: From: Guenter Roeck This patch adds support for the IMS (now Zodiac Inflight Innovations) SCU Generation 1/2/3 platform driver. This

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread Florian Fainelli
On 01/13/2017 08:38 AM, Andy Shevchenko wrote: > On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli > wrote: >> From: Guenter Roeck >> >> This patch adds support for the IMS (now Zodiac Inflight Innovations) >> SCU Generation 1/2/3 platform driver. This

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread Florian Fainelli
On 01/13/2017 08:38 AM, Andy Shevchenko wrote: > On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli > wrote: >> From: Guenter Roeck >> >> This patch adds support for the IMS (now Zodiac Inflight Innovations) >> SCU Generation 1/2/3 platform driver. This driver registers all the >> on-module

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread Florian Fainelli
On 01/13/2017 10:22 AM, Darren Hart wrote: >> Btw, Darren, would it be good idea to start creating folders to make a >> bit of order in the subsystem? For first I would move Intel's PMIC/SCU >> stuff to somewhere (not sure if it should be per manufacturer or per >> function). > > If we create

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread Florian Fainelli
On 01/13/2017 10:22 AM, Darren Hart wrote: >> Btw, Darren, would it be good idea to start creating folders to make a >> bit of order in the subsystem? For first I would move Intel's PMIC/SCU >> stuff to somewhere (not sure if it should be per manufacturer or per >> function). > > If we create

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread Darren Hart
On Fri, Jan 13, 2017 at 06:38:28PM +0200, Andy Shevchenko wrote: > On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli > wrote: > > From: Guenter Roeck > > > > This patch adds support for the IMS (now Zodiac Inflight Innovations) > > SCU Generation 1/2/3

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread Darren Hart
On Fri, Jan 13, 2017 at 06:38:28PM +0200, Andy Shevchenko wrote: > On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli > wrote: > > From: Guenter Roeck > > > > This patch adds support for the IMS (now Zodiac Inflight Innovations) > > SCU Generation 1/2/3 platform driver. This driver registers

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread Andy Shevchenko
On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli wrote: > From: Guenter Roeck > > This patch adds support for the IMS (now Zodiac Inflight Innovations) > SCU Generation 1/2/3 platform driver. This driver registers all the > on-module peripherals:

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread Andy Shevchenko
On Wed, Jan 11, 2017 at 11:26 PM, Florian Fainelli wrote: > From: Guenter Roeck > > This patch adds support for the IMS (now Zodiac Inflight Innovations) > SCU Generation 1/2/3 platform driver. This driver registers all the > on-module peripherals: Ethernet switches (Broadcom or Marvell), I2C to

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread kbuild test robot
Hi Guenter, [auto build test WARNING on platform-drivers-x86/for-next] [also build test WARNING on v4.10-rc3 next-20170113] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-13 Thread kbuild test robot
Hi Guenter, [auto build test WARNING on platform-drivers-x86/for-next] [also build test WARNING on v4.10-rc3 next-20170113] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

[PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-11 Thread Florian Fainelli
From: Guenter Roeck This patch adds support for the IMS (now Zodiac Inflight Innovations) SCU Generation 1/2/3 platform driver. This driver registers all the on-module peripherals: Ethernet switches (Broadcom or Marvell), I2C to GPIO expanders, Kontrom CPLD/I2C master, and

[PATCH] platform/x86: Add IMS/ZII SCU driver

2017-01-11 Thread Florian Fainelli
From: Guenter Roeck This patch adds support for the IMS (now Zodiac Inflight Innovations) SCU Generation 1/2/3 platform driver. This driver registers all the on-module peripherals: Ethernet switches (Broadcom or Marvell), I2C to GPIO expanders, Kontrom CPLD/I2C master, and more. Signed-off-by: