On Thu, Dec 14, 2017 at 11:12 AM, Dhaval Shah
wrote:
> I got your point. SPDX text should be "SPDX-License-Identifier: GPL-2.0+".
> Am i Right?
Whatever you come up with I will apply taking into consideration the following:
1. Linus' preference over comment style.
2. Module author(s) blessing fo
orm/x86: dell-rbtn: Block comments use * on
> subsequent lines
>
> On Wed, 2017-12-13 at 12:41 +, Dhaval Shah wrote:
> > > If anyone does conversions of these license texts
> > > you have to be _extremely_ careful about what
> > > specific license id
On Wed, 2017-12-13 at 12:41 +, Dhaval Shah wrote:
> > If anyone does conversions of these license texts
> > you have to be _extremely_ careful about what
> > specific license identifier you use.
> > This license includes the text
> > "or (at your option) any later version"
> > which is
platform/x86: dell-rbtn: Block comments use * on
> subsequent lines
>
> Dhaval,
>
> On Wed, Dec 13, 2017 at 11:47 AM, Dhaval Shah
> wrote:
>
>
> > > And for a short comment block like this, Linus preference is to avoid
> > > mixing comment style and g
On Wednesday 13 December 2017 12:41:03 Dhaval Shah wrote:
> I have given this SPDX ID based on the current license info in the driver.
> Yeah. I give the authority to author pali.ro...@gmail.com to decide the SPDX
> text.
Hi! I think that license of this module is clear and does not need more
co
Dhaval,
On Wed, Dec 13, 2017 at 11:47 AM, Dhaval Shah
wrote:
> > And for a short comment block like this, Linus preference is to avoid
> > mixing comment style and go all the way C++ style as in:
> >
> > > // SPDX-License-Identifier: GPL-2.0
> > > // Dell Airplane Mode Switch driver
> > > // Co
ATCH] platform/x86: dell-rbtn: Block comments use * on
> subsequent lines
>
> On Wed, 2017-12-13 at 10:53 +, Dhaval Shah wrote:
> > > > This is different issue. If we need to fix the issue of this if we
> > > > update SPDX licensing as well.
> > > > I
On Wed, 2017-12-13 at 10:53 +, Dhaval Shah wrote:
> > > This is different issue. If we need to fix the issue of this if we update
> > > SPDX licensing as well.
> > > I am agree with you on the use of the new SPDX IDs instead of the long
> > > legalese.
> > > For this, we have to add the text
: Wednesday, December 13, 2017 2:54 PM
> > > To: Dhaval Shah
> > > Cc: pali.ro...@gmail.com; Darren Hart; Andy Shevchenko;
> > > platform-driver-...@vger.kernel.org; LKML
> > > Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on
> > > subsequ
il.com; Darren Hart; Andy Shevchenko;
>> platform-driver-...@vger.kernel.org; LKML
>> Subject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on
>> subsequent lines
>>
>> Dhaval,
>>
>> On Wed, Dec 13, 2017 at 9:23 AM, Dhaval Shah
>>
ubject: Re: [PATCH] platform/x86: dell-rbtn: Block comments use * on
> subsequent lines
>
> Dhaval,
>
> On Wed, Dec 13, 2017 at 9:23 AM, Dhaval Shah
> wrote:
> > Resolved Block comments use * on subsequent lines checkpatch warnings.
> > Issue found by checkpatch.
> >
Dhaval,
On Wed, Dec 13, 2017 at 9:23 AM, Dhaval Shah
wrote:
> Resolved Block comments use * on subsequent lines checkpatch warnings.
> Issue found by checkpatch.
>
> Signed-off-by: Dhaval Shah
> ---
> drivers/platform/x86/dell-rbtn.c | 26 +-
> drivers/platform/x86/dell-
Resolved Block comments use * on subsequent lines checkpatch warnings.
Issue found by checkpatch.
Signed-off-by: Dhaval Shah
---
drivers/platform/x86/dell-rbtn.c | 26 +-
drivers/platform/x86/dell-rbtn.h | 26 +-
2 files changed, 26 insertions(+),
13 matches
Mail list logo
