Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static

2019-04-05 Thread Andy Shevchenko
On Fri, Apr 5, 2019 at 5:49 PM Bhardwaj, Rajneesh wrote: > Sending again as i got delivery failure notification from the mailing > list for some reason. Mailing list doesn't accept HTML as was your previous message. -- With Best Regards, Andy Shevchenko

Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static

2019-04-05 Thread Bhardwaj, Rajneesh
Sending again as i got delivery failure notification from the mailing list for some reason. On 05-Apr-19 8:15 PM, Andy Shevchenko wrote: On Wed, Mar 27, 2019 at 2:47 PM Bhardwaj, Rajneesh wrote: On 27-Mar-19 1:59 AM, Guenter Roeck wrote: 0day reports: drivers/platform/x86/intel_pmc_core.c:

Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static

2019-04-05 Thread Andy Shevchenko
On Wed, Mar 27, 2019 at 2:47 PM Bhardwaj, Rajneesh wrote: > > > On 27-Mar-19 1:59 AM, Guenter Roeck wrote: > > 0day reports: > > > > drivers/platform/x86/intel_pmc_core.c:833:5: sparse: > > symbol 'quirk_xtal_ignore' was not declared. Should it be static? > > Looks good to me. Please, give

Re: [PATCH] platform/x86: intel_pmc_core: Mark local function static

2019-03-27 Thread Bhardwaj, Rajneesh
On 27-Mar-19 1:59 AM, Guenter Roeck wrote: 0day reports: drivers/platform/x86/intel_pmc_core.c:833:5: sparse: symbol 'quirk_xtal_ignore' was not declared. Should it be static? Looks good to me. Mark the function static since it is indeed only called locally. Cc: Rajneesh Bhardwaj

[PATCH] platform/x86: intel_pmc_core: Mark local function static

2019-03-26 Thread Guenter Roeck
0day reports: drivers/platform/x86/intel_pmc_core.c:833:5: sparse: symbol 'quirk_xtal_ignore' was not declared. Should it be static? Mark the function static since it is indeed only called locally. Cc: Rajneesh Bhardwaj Fixes: 238f9c11351f ("platform/x86: intel_pmc_core: Quirk to ignore