RE: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch.

2020-08-04 Thread Yuan, Perry
> From: Andy Shevchenko > Sent: Wednesday, July 29, 2020 3:32 PM > To: Yuan, Perry > Cc: Sebastian Reichel; Matthew Garrett; Pali Rohár; Darren Hart; Andy > Shevchenko; Limonciello, Mario; Linux PM; Linux Kernel Mailing List; Platform > Driver > Subject: Re: [PATCH] platfor

RE: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch.

2020-08-04 Thread Yuan, Perry
el@vger.kernel.org; platform-driver- > x...@vger.kernel.org > Subject: Re: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds > and charging mode switch. > > > [EXTERNAL EMAIL] > > On Tue, Aug 04, 2020 at 05:46:30AM +, Yuan, Perry wrote: > > > It

Re: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch.

2020-08-03 Thread Matthew Garrett
On Tue, Aug 04, 2020 at 05:46:30AM +, Yuan, Perry wrote: > It is not patch issue, the kernel config needs to add "CONFIG_ACPI_BATTERY=y" In that case you probably want to add a dependency to ACPI_BATTERY in the DELL_LAPTOP Kconfig. -- Matthew Garrett | mj...@srcf.ucam.org

RE: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch.

2020-08-03 Thread Yuan, Perry
..@vger.kernel.org; platform-driver-...@vger.kernel.org; Yuan, Perry > Subject: Re: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds > and charging mode switch. > > > [EXTERNAL EMAIL] > > Hi Perry, > > Thank you for the patch! Yet something to improve

Re: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch.

2020-07-31 Thread kernel test robot
Hi Perry, Thank you for the patch! Yet something to improve: [auto build test ERROR on power-supply/for-next] [also build test ERROR on linux/master linus/master v5.8-rc7 next-20200731] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

Re: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch.

2020-07-29 Thread Limonciello, Mario
> The values here seem very Dell specific, but this is going into a > generic sysfs path. Really stuff here should be as vendor independent as > possible. If these values don't correspond to a wider industry > specification it probably makes sense to make this something Dell > specific. Worth

Re: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch.

2020-07-29 Thread Matthew Garrett
On Tue, Jul 28, 2020 at 11:54:24PM -0700, Perry Yuan wrote: This seems extremely useful, but: > diff --git a/Documentation/ABI/testing/sysfs-class-power > b/Documentation/ABI/testing/sysfs-class-power > index bf3b48f022dc..a8adc3b0ca4b 100644 > --- a/Documentation/ABI/testing/sysfs-class-power

Re: [PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch.

2020-07-29 Thread Andy Shevchenko
On Wed, Jul 29, 2020 at 9:54 AM Perry Yuan wrote: > > From: perry_yuan Fix your name, please. Or do you have it spelled in the official documents like above? > The patch control battery charging thresholds when system is under custom > charging mode through smbios API and driver`s sys

[PATCH] platform/x86:dell-laptop:Add battery charging thresholds and charging mode switch.

2020-07-29 Thread Perry Yuan
From: perry_yuan The patch control battery charging thresholds when system is under custom charging mode through smbios API and driver`s sys attributes.It also set the percentage bounds for custom charge. Start value must lie in the range [50, 95],End value must lie in the range [55, 100],END