Re: [PATCH] posix-cpu-timers: fix nanosleep task_struct leak

2013-02-07 Thread Oleg Nesterov
On 02/07, Stanislaw Gruszka wrote: > > On Wed, Feb 06, 2013 at 05:10:11PM +0100, Oleg Nesterov wrote: > > > > It is not clear to me why other posix_cpu_timer_del's above can't fail.. > > May be you can add a comment. > > Sure, I'll add more comments. Yes, please. This will help the next reader to

Re: [PATCH] posix-cpu-timers: fix nanosleep task_struct leak

2013-02-07 Thread Stanislaw Gruszka
On Wed, Feb 06, 2013 at 05:10:11PM +0100, Oleg Nesterov wrote: > First of all, thank you so much. I knew it was a good idea to cc you ;) :-) > On 02/06, Stanislaw Gruszka wrote: > > > > In do_cpu_nanosleep() we do posix_cpu_timer_create(), but forgot > > corresponding posix_cpu_timer_del(), what

Re: [PATCH] posix-cpu-timers: fix nanosleep task_struct leak

2013-02-06 Thread Oleg Nesterov
Stanislaw, First of all, thank you so much. I knew it was a good idea to cc you ;) And let me repeat that I forgot everything about this code. On 02/06, Stanislaw Gruszka wrote: > > In do_cpu_nanosleep() we do posix_cpu_timer_create(), but forgot > corresponding posix_cpu_timer_del(), what lead

[PATCH] posix-cpu-timers: fix nanosleep task_struct leak

2013-02-06 Thread Stanislaw Gruszka
In do_cpu_nanosleep() we do posix_cpu_timer_create(), but forgot corresponding posix_cpu_timer_del(), what lead to task_struct leak. Reported-and-tested-by: Tommi Rantala Signed-off-by: Stanislaw Gruszka --- kernel/posix-cpu-timers.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletio