Re: [PATCH] posix_acl: fix reference leaks in posix_acl_create

2015-02-02 Thread Christoph Hellwig
On Sun, Feb 01, 2015 at 11:55:02PM -0800, Omar Sandoval wrote: > There are already a couple of return paths in posix_acl_create, and > there are only these two error cases, so I think gotos might actually > make the code more confusing. In any case, here's an idea: > > posix_acl: fix reference lea

Re: [PATCH] posix_acl: fix reference leaks in posix_acl_create

2015-02-01 Thread Omar Sandoval
On Wed, Jan 28, 2015 at 06:09:52PM +0100, Christoph Hellwig wrote: > On Mon, Jan 26, 2015 at 10:16:53PM -0800, Omar Sandoval wrote: > > get_acl gets a reference which we must release in the error cases. > > > > Signed-off-by: Omar Sandoval > > Looks good, but at this point goto-based unwinding m

Re: [PATCH] posix_acl: fix reference leaks in posix_acl_create

2015-01-28 Thread Christoph Hellwig
On Mon, Jan 26, 2015 at 10:16:53PM -0800, Omar Sandoval wrote: > get_acl gets a reference which we must release in the error cases. > > Signed-off-by: Omar Sandoval Looks good, but at this point goto-based unwinding might be in order. -- To unsubscribe from this list: send the line "unsubscribe

[PATCH] posix_acl: fix reference leaks in posix_acl_create

2015-01-26 Thread Omar Sandoval
get_acl gets a reference which we must release in the error cases. Signed-off-by: Omar Sandoval --- fs/posix_acl.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/fs/posix_acl.c b/fs/posix_acl.c index 0855f77..f8f3cc2 100644 --- a/fs/posix_acl.c +++ b/fs/posix_acl.c @@ -5