Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

2021-03-09 Thread Chanwoo Choi
Hi Krzysztof, On 3/9/21 1:11 AM, Krzysztof Kozlowski wrote: > On Mon, 8 Mar 2021 at 17:02, Arnd Bergmann wrote: >> >> On Mon, Mar 8, 2021 at 4:33 PM Krzysztof Kozlowski wrote: >>> >>> On 08/03/2021 16:29, Arnd Bergmann wrote: From: Arnd Bergmann Some of the extcon interfaces

Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

2021-03-08 Thread Vaittinen, Matti
On Mon, 2021-03-08 at 18:06 +0200, Andy Shevchenko wrote: > On Mon, Mar 8, 2021 at 5:29 PM Arnd Bergmann wrote: > > > - depends on EXTCON || !EXTCON > > I stumbled over this. > What is the point of having this line at all? > What magic trick does it serve for? The logic was somewhat

Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

2021-03-08 Thread Krzysztof Kozlowski
On Mon, 8 Mar 2021 at 17:02, Arnd Bergmann wrote: > > On Mon, Mar 8, 2021 at 4:33 PM Krzysztof Kozlowski wrote: > > > > On 08/03/2021 16:29, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Some of the extcon interfaces have a fallback implementation that can > > > be used when EXTCON

Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

2021-03-08 Thread Andy Shevchenko
On Mon, Mar 8, 2021 at 6:06 PM Andy Shevchenko wrote: > On Mon, Mar 8, 2021 at 5:29 PM Arnd Bergmann wrote: > > > - depends on EXTCON || !EXTCON > > I stumbled over this. > What is the point of having this line at all? > What magic trick does it serve for? Okay, it seems I can answer my

Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

2021-03-08 Thread Arnd Bergmann
On Mon, Mar 8, 2021 at 4:52 PM Matti Vaittinen wrote: > > Hello Arnd, > > On Mon, 2021-03-08 at 16:29 +0100, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > I assume there is no reason to actually build this driver without > > extcon > > support, so a hard dependency is the easiest fix.

Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

2021-03-08 Thread Andy Shevchenko
On Mon, Mar 8, 2021 at 5:29 PM Arnd Bergmann wrote: > - depends on EXTCON || !EXTCON I stumbled over this. What is the point of having this line at all? What magic trick does it serve for? -- With Best Regards, Andy Shevchenko

Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

2021-03-08 Thread Arnd Bergmann
On Mon, Mar 8, 2021 at 4:33 PM Krzysztof Kozlowski wrote: > > On 08/03/2021 16:29, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > Some of the extcon interfaces have a fallback implementation that can > > be used when EXTCON is disabled, but some others do not, causing a > > build failure:

Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

2021-03-08 Thread Matti Vaittinen
Hello Arnd, On Mon, 2021-03-08 at 16:29 +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > I assume there is no reason to actually build this driver without > extcon > support, so a hard dependency is the easiest fix. Alternatively the > header file could be extended to provide additional

Re: [PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

2021-03-08 Thread Krzysztof Kozlowski
On 08/03/2021 16:29, Arnd Bergmann wrote: > From: Arnd Bergmann > > Some of the extcon interfaces have a fallback implementation that can > be used when EXTCON is disabled, but some others do not, causing a > build failure: > > drivers/power/supply/max8997_charger.c:261:9: error: implicit

[PATCH] power: supply: max8997_charger: make EXTCON dependency unconditional

2021-03-08 Thread Arnd Bergmann
From: Arnd Bergmann Some of the extcon interfaces have a fallback implementation that can be used when EXTCON is disabled, but some others do not, causing a build failure: drivers/power/supply/max8997_charger.c:261:9: error: implicit declaration of function 'devm_extcon_register_notifier_all'