Re: [PATCH] powerpc, perf: Fix processing conditions for invalid BHRB entries

2013-05-06 Thread Michael Neuling
Anshuman Khandual wrote: > On 05/06/2013 04:41 PM, Michael Neuling wrote: > > Anshuman Khandual wrote: > > > >> Fixing some conditions during BHRB entry processing. > > > > I think we can simplify this a lot more... something like the below. > > > > I feel that the conditional handling of th

Re: [PATCH] powerpc, perf: Fix processing conditions for invalid BHRB entries

2013-05-06 Thread Anshuman Khandual
On 05/06/2013 04:41 PM, Michael Neuling wrote: > Anshuman Khandual wrote: > >> Fixing some conditions during BHRB entry processing. > > I think we can simplify this a lot more... something like the below. > I feel that the conditional handling of the invalid BHRB entries should be present whic

Re: [PATCH] powerpc, perf: Fix processing conditions for invalid BHRB entries

2013-05-06 Thread Michael Neuling
Anshuman Khandual wrote: > Fixing some conditions during BHRB entry processing. I think we can simplify this a lot more... something like the below. Also, this marks the "to" address as all 1s, which is better poison value since it's possible to branch to/from 0x0. diff --git a/arch/powerpc/pe

[PATCH] powerpc, perf: Fix processing conditions for invalid BHRB entries

2013-05-06 Thread Anshuman Khandual
Fixing some conditions during BHRB entry processing. Signed-off-by: Anshuman Khandual --- arch/powerpc/perf/core-book3s.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/powerpc/perf/core-book3s.c b/arch/powerpc/perf/core-book3s.c index 09db68d..1de2756 100644 --