Re: [PATCH] powerpc/32s: Fix RTAS machine check with VMAP stack

2020-12-23 Thread Michael Ellerman
Christophe Leroy writes: > Le 22/12/2020 à 08:11, Christophe Leroy a écrit : >> When we have VMAP stack, exception prolog 1 sets r1, not r11. > > But exception prolog 1 uses r1 to setup r1 when machine check happens in > kernel. > So r1 must be restored when the branch is not taken. See subsequen

Re: [PATCH] powerpc/32s: Fix RTAS machine check with VMAP stack

2020-12-22 Thread Christophe Leroy
Le 22/12/2020 à 08:11, Christophe Leroy a écrit : When we have VMAP stack, exception prolog 1 sets r1, not r11. But exception prolog 1 uses r1 to setup r1 when machine check happens in kernel. So r1 must be restored when the branch is not taken. See subsequent patch I just sent out. Christ

[PATCH] powerpc/32s: Fix RTAS machine check with VMAP stack - again

2020-12-22 Thread Christophe Leroy
When it is not a RTAS machine check, don't trash r1 because it is needed by prolog 1. Fixes: 9c7422b92cb2 ("powerpc/32s: Fix RTAS machine check with VMAP stack") Cc: sta...@vger.kernel.org Signed-off-by: Christophe Leroy --- Sorry Michael for this last minute fix of the fix. arch/powerpc/kernel

Re: [PATCH] powerpc/32s: Fix RTAS machine check with VMAP stack

2020-12-22 Thread Michael Ellerman
On Tue, 22 Dec 2020 07:11:18 + (UTC), Christophe Leroy wrote: > When we have VMAP stack, exception prolog 1 sets r1, not r11. Applied to powerpc/fixes. [1/1] powerpc/32s: Fix RTAS machine check with VMAP stack https://git.kernel.org/powerpc/c/9c7422b92cb27369653c371ad9c44a502e5eea8f ch

[PATCH] powerpc/32s: Fix RTAS machine check with VMAP stack

2020-12-21 Thread Christophe Leroy
When we have VMAP stack, exception prolog 1 sets r1, not r11. Fixes: da7bb43ab9da ("powerpc/32: Fix vmap stack - Properly set r1 before activating MMU") Fixes: d2e006036082 ("powerpc/32: Use SPRN_SPRG_SCRATCH2 in exception prologs") Cc: sta...@vger.kernel.org Signed-off-by: Christophe Leroy ---