Re: [PATCH] powerpc/prom_init: add __init markers to all functions

2019-02-06 Thread Michael Ellerman
Masahiro Yamada writes: > On Tue, Feb 5, 2019 at 7:33 PM Michael Ellerman wrote: >> >> Masahiro Yamada writes: >> >> > It is fragile to rely on the compiler's optimization to avoid the >> > section mismatch. Some functions may not be necessarily inlined >> > when the compiler's inlining heuristi

Re: [PATCH] powerpc/prom_init: add __init markers to all functions

2019-02-05 Thread Masahiro Yamada
On Tue, Feb 5, 2019 at 7:33 PM Michael Ellerman wrote: > > Masahiro Yamada writes: > > > It is fragile to rely on the compiler's optimization to avoid the > > section mismatch. Some functions may not be necessarily inlined > > when the compiler's inlining heuristic changes. > > > > Add __init mar

Re: [PATCH] powerpc/prom_init: add __init markers to all functions

2019-02-05 Thread Michael Ellerman
Masahiro Yamada writes: > It is fragile to rely on the compiler's optimization to avoid the > section mismatch. Some functions may not be necessarily inlined > when the compiler's inlining heuristic changes. > > Add __init markers consistently. > > As for prom_getprop() and prom_getproplen(), the

Re: [PATCH] powerpc/prom_init: add __init markers to all functions

2019-01-30 Thread kbuild test robot
Hi Masahiro, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v5.0-rc4 next-20190130] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commit

[PATCH] powerpc/prom_init: add __init markers to all functions

2019-01-30 Thread Masahiro Yamada
It is fragile to rely on the compiler's optimization to avoid the section mismatch. Some functions may not be necessarily inlined when the compiler's inlining heuristic changes. Add __init markers consistently. As for prom_getprop() and prom_getproplen(), they are marked as 'inline', so inlining