Re: [PATCH] powerpc: add new required termio functions

2007-09-14 Thread Alan Cox
On Wed, Sep 12, 2007 at 02:49:10PM +0100, Christoph Hellwig wrote: > On Wed, Sep 12, 2007 at 01:52:57PM +0200, Heiko Carstens wrote: > > > I might be missing something, but the the right fix is probably to > > > apply the arch patches from Alan to powerpc and s390. We don't want to > > > be left

Re: [PATCH] powerpc: add new required termio functions

2007-09-14 Thread Alan Cox
On Wed, Sep 12, 2007 at 02:49:10PM +0100, Christoph Hellwig wrote: On Wed, Sep 12, 2007 at 01:52:57PM +0200, Heiko Carstens wrote: I might be missing something, but the the right fix is probably to apply the arch patches from Alan to powerpc and s390. We don't want to be left over

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Christoph Hellwig
On Wed, Sep 12, 2007 at 01:52:57PM +0200, Heiko Carstens wrote: > > I might be missing something, but the the right fix is probably to > > apply the arch patches from Alan to powerpc and s390. We don't want to > > be left over without all the nice termios features on these platforms, > > do we? >

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Heiko Carstens
On Wed, Sep 12, 2007 at 12:34:09PM +0100, Christoph Hellwig wrote: > On Wed, Sep 12, 2007 at 04:01:09AM -0700, Andrew Morton wrote: > > On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > > > > On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > > > >

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Christoph Hellwig
On Wed, Sep 12, 2007 at 04:01:09AM -0700, Andrew Morton wrote: > On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > > On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > > > The "tty: termios locking functions break with new termios type" patch > > >

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Michael Neuling
In message <[EMAIL PROTECTED]> you wrote: > On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote: > > > On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > > > The "tty: termios locking functions break with new termios type" patch > > >

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Andrew Morton
On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens <[EMAIL PROTECTED]> wrote: > On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > > The "tty: termios locking functions break with new termios type" patch > > (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. > >

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Heiko Carstens
On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: > The "tty: termios locking functions break with new termios type" patch > (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. > [...] > I'm guessing other architectures are broken too? FWIW, the above quoted

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Heiko Carstens
On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: The tty: termios locking functions break with new termios type patch (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. [...] I'm guessing other architectures are broken too? FWIW, the above quoted patch

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Andrew Morton
On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens [EMAIL PROTECTED] wrote: On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: The tty: termios locking functions break with new termios type patch (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. [...]

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Michael Neuling
In message [EMAIL PROTECTED] you wrote: On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens [EMAIL PROTECTED] wrote: On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: The tty: termios locking functions break with new termios type patch

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Christoph Hellwig
On Wed, Sep 12, 2007 at 04:01:09AM -0700, Andrew Morton wrote: On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens [EMAIL PROTECTED] wrote: On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: The tty: termios locking functions break with new termios type patch

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Heiko Carstens
On Wed, Sep 12, 2007 at 12:34:09PM +0100, Christoph Hellwig wrote: On Wed, Sep 12, 2007 at 04:01:09AM -0700, Andrew Morton wrote: On Wed, 12 Sep 2007 12:20:32 +0200 Heiko Carstens [EMAIL PROTECTED] wrote: On Wed, Sep 12, 2007 at 12:04:39PM +1000, Michael Neuling wrote: The tty:

Re: [PATCH] powerpc: add new required termio functions

2007-09-12 Thread Christoph Hellwig
On Wed, Sep 12, 2007 at 01:52:57PM +0200, Heiko Carstens wrote: I might be missing something, but the the right fix is probably to apply the arch patches from Alan to powerpc and s390. We don't want to be left over without all the nice termios features on these platforms, do we? But

Re: [PATCH] powerpc: add new required termio functions

2007-09-11 Thread Geoff Levand
Michael Neuling wrote: > The "tty: termios locking functions break with new termios type" patch > (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. > This adds the required API to asm-powerpc. > > Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> > -- > This needs to go up

Re: [PATCH] powerpc: add new required termio functions

2007-09-11 Thread Tony Breeds
On Tue, Sep 11, 2007 at 07:17:42PM -0700, Linus Torvalds wrote: > Really? > > It shouldn't. The use of kernel_termios_to_user_termios_1() is conditional > on the architecture having a define for TCGETS2, and I think they match > up. I see: > > [EMAIL PROTECTED] linux]$ git grep -l

Re: [PATCH] powerpc: add new required termio functions

2007-09-11 Thread Michael Neuling
> On Wed, 12 Sep 2007, Michael Neuling wrote: > > > > The "tty: termios locking functions break with new termios type" patch > > (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. > > Really? > > It shouldn't. The use of kernel_termios_to_user_termios_1() is conditional > on

Re: [PATCH] powerpc: add new required termio functions

2007-09-11 Thread Linus Torvalds
On Wed, 12 Sep 2007, Michael Neuling wrote: > > The "tty: termios locking functions break with new termios type" patch > (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. Really? It shouldn't. The use of kernel_termios_to_user_termios_1() is conditional on the

[PATCH] powerpc: add new required termio functions

2007-09-11 Thread Michael Neuling
The "tty: termios locking functions break with new termios type" patch (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. This adds the required API to asm-powerpc. Signed-off-by: Michael Neuling <[EMAIL PROTECTED]> -- This needs to go up for 2.6.23. Should we really put

[PATCH] powerpc: add new required termio functions

2007-09-11 Thread Michael Neuling
The tty: termios locking functions break with new termios type patch (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. This adds the required API to asm-powerpc. Signed-off-by: Michael Neuling [EMAIL PROTECTED] -- This needs to go up for 2.6.23. Should we really put these

Re: [PATCH] powerpc: add new required termio functions

2007-09-11 Thread Linus Torvalds
On Wed, 12 Sep 2007, Michael Neuling wrote: The tty: termios locking functions break with new termios type patch (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. Really? It shouldn't. The use of kernel_termios_to_user_termios_1() is conditional on the architecture

Re: [PATCH] powerpc: add new required termio functions

2007-09-11 Thread Tony Breeds
On Tue, Sep 11, 2007 at 07:17:42PM -0700, Linus Torvalds wrote: Really? It shouldn't. The use of kernel_termios_to_user_termios_1() is conditional on the architecture having a define for TCGETS2, and I think they match up. I see: [EMAIL PROTECTED] linux]$ git grep -l

Re: [PATCH] powerpc: add new required termio functions

2007-09-11 Thread Michael Neuling
On Wed, 12 Sep 2007, Michael Neuling wrote: The tty: termios locking functions break with new termios type patch (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. Really? It shouldn't. The use of kernel_termios_to_user_termios_1() is conditional on the

Re: [PATCH] powerpc: add new required termio functions

2007-09-11 Thread Geoff Levand
Michael Neuling wrote: The tty: termios locking functions break with new termios type patch (f629307c857c030d5a3dd777fee37c8bb395e171) breaks the powerpc compile. This adds the required API to asm-powerpc. Signed-off-by: Michael Neuling [EMAIL PROTECTED] -- This needs to go up for 2.6.23.