Re: [PATCH] ppc32: CPM2 PIC cleanup irq_to_siubit array

2005-03-29 Thread Kumar Gala
Done, updated patch w/comment sent to Andrew. - kumar On Mar 29, 2005, at 7:10 PM, Dan Malek wrote: On Mar 29, 2005, at 5:30 PM, Kumar Gala wrote: > Cleaned up irq_to_siubit array so we no longer need to do 1 << > (31-bit), > just 1 << bit. Will you please put a comment in here that indicates thi

[PATCH] ppc32: CPM2 PIC cleanup irq_to_siubit array (updated)

2005-03-29 Thread Kumar Gala
Andrew, (Updated this patch to include a comment at Dan Malek's request.) Cleaned up irq_to_siubit array so we no longer need to do 1 << (31-bit), just 1 << bit. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- diff -Nru a/arch/ppc/syslib/cpm2_pic.c b/arch/ppc/syslib/cpm2_pic.c --- a/arch/pp

Re: [PATCH] ppc32: CPM2 PIC cleanup irq_to_siubit array

2005-03-29 Thread Dan Malek
On Mar 29, 2005, at 5:30 PM, Kumar Gala wrote: Cleaned up irq_to_siubit array so we no longer need to do 1 << (31-bit), just 1 << bit. Will you please put a comment in here that indicates this array now has this computation done? When I wrote it, these bit numbers matched the registers and the do

[PATCH] ppc32: CPM2 PIC cleanup irq_to_siubit array

2005-03-29 Thread Kumar Gala
Andrew, Cleaned up irq_to_siubit array so we no longer need to do 1 << (31-bit), just 1 << bit. Signed-off-by: Kumar Gala <[EMAIL PROTECTED]> --- diff -Nru a/arch/ppc/syslib/cpm2_pic.c b/arch/ppc/syslib/cpm2_pic.c --- a/arch/ppc/syslib/cpm2_pic.c2005-03-29 16:25:34 -06:00 +++ b/arch/pp

Re: [PATCH] ppc32: CPM2 PIC cleanup

2005-03-29 Thread Eugene Surovegin
On Tue, Mar 29, 2005 at 10:42:29AM -0600, Kumar Gala wrote: > Andrew, > > Cleaned up the CPM2 interrupt controller code: > * Added the ability to offset the IRQs > * Refactored common PIC init code out of platform files > * Fixed IRQ offsets on MPC85xx so it can handle properly handled multiple >

[PATCH] ppc32: CPM2 PIC cleanup

2005-03-29 Thread Kumar Gala
Andrew, Cleaned up the CPM2 interrupt controller code: * Added the ability to offset the IRQs * Refactored common PIC init code out of platform files * Fixed IRQ offsets on MPC85xx so it can handle properly handled multiple interrupt controllers (i8259, CPM2 PIC, and OpenPIC) Signed-off-by: Jaso