2015-03-16 21:09 GMT+06:00 Joe Perches :
> On Mon, 2015-03-16 at 15:01 +0600, Alexander Kuleshov wrote:
>> Signed-off-by: Alexander Kuleshov
>
> Perhaps the entries for #define CONSOLE_LOGLEVEL_
> from printk.h and #define LOGLEVEL_ from kern_levels.h
> can be consolidated and rationalized as well
On Mon, 2015-03-16 at 15:01 +0600, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov
Perhaps the entries for #define CONSOLE_LOGLEVEL_
from printk.h and #define LOGLEVEL_ from kern_levels.h
can be consolidated and rationalized as well.
--
To unsubscribe from this list: send the lin
Hi Alexander,
On Mon, Mar 16, 2015 at 11:50 AM, Alexander Kuleshov
wrote:
> Yes, i thougt about this issue. I looked in git history and found the
> commit - a8fe19ebfbfd90ec17c02284717238b02efb9580 where level 8
> changed on 10,
> so i decided to put CONSOLE_LOGLEVEL_DEBUG here.
Thanks, that mak
Hello Geert,
Yes, i thougt about this issue. I looked in git history and found the
commit - a8fe19ebfbfd90ec17c02284717238b02efb9580 where level 8
changed on 10,
so i decided to put CONSOLE_LOGLEVEL_DEBUG here.
2015-03-16 15:20 GMT+06:00 Geert Uytterhoeven :
> On Mon, Mar 16, 2015 at 10:01 AM, A
On Mon, 2015-03-16 at 15:01 +0600, Alexander Kuleshov wrote:
> Signed-off-by: Alexander Kuleshov
> ---
> diff --git a/arch/powerpc/kernel/udbg.c b/arch/powerpc/kernel/udbg.c
> index b7aa072..5525a85 100644
> --- a/arch/powerpc/kernel/udbg.c
> +++ b/arch/powerpc/kernel/udbg.c
> @@ -76,7 +76,7 @@ vo
On Mon, Mar 16, 2015 at 10:01 AM, Alexander Kuleshov
wrote:
> --- a/arch/m68k/mac/macints.c
> +++ b/arch/m68k/mac/macints.c
> @@ -315,7 +315,7 @@ irqreturn_t mac_nmi_handler(int irq, void *dev_id)
> while (nmi_hold == 1)
> udelay(1000);
>
> - if (console_loglevel >= 8
Signed-off-by: Alexander Kuleshov
---
arch/arm/mach-omap2/serial.c | 2 +-
arch/m68k/mac/macints.c | 2 +-
arch/m68k/mac/oss.c | 4 ++--
arch/powerpc/kernel/udbg.c | 2 +-
4 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-o
On Tue, May 27, 2014 at 04:26:44PM -0700, Andrew Morton wrote:
> On Wed, 28 May 2014 00:59:57 +0200 Borislav Petkov wrote:
>
> > @Andrew: can you please replace the sentence:
> >
> > "There should be no functionality change resulting from this patch."
> >
> > with
> >
> > "Also, correct the ch
On Tue, 27 May 2014 16:26:44 -0700
Andrew Morton wrote:
> > so that Steve can sleep tonight? :-)
>
> I think Steve only comes out at night.
Of course. That's because night time is the best time to hit those
Japanese heated toilet seats.
-- Steve
--
To unsubscribe from this list: send the lin
On Wed, 28 May 2014 00:59:57 +0200 Borislav Petkov wrote:
> @Andrew: can you please replace the sentence:
>
> "There should be no functionality change resulting from this patch."
>
> with
>
> "Also, correct the check in x86_64_start_kernel which should be >= as
> we're clearly issuing the stri
On Tue, May 27, 2014 at 06:36:24PM -0400, valdis.kletni...@vt.edu wrote:
> If you don't split it out, you should at least mention the bugfix in
> the changelog
Ok ok, I give up. Steve is bugging me on IRC about it, too. Damn. Ok, I
got it.
@Andrew: can you please replace the sentence:
"There
On Tue, 27 May 2014 21:43:59 +0200, Borislav Petkov said:
> On Tue, May 27, 2014 at 03:17:28PM -0400, Steven Rostedt wrote:
> > This looks like functionality change to me.
> >
> > Please make the fix of "==" --> ">=" a separate patch.
>
> Yeah, that's actually a fix for console_loglevel values > 10
On Tue, May 27, 2014 at 03:17:28PM -0400, Steven Rostedt wrote:
> This looks like functionality change to me.
>
> Please make the fix of "==" --> ">=" a separate patch.
Yeah, that's actually a fix for console_loglevel values > 10. I don't
think it is worth the effort of splitting though ... unles
On Mon, 19 May 2014 20:27:32 +0200
Borislav Petkov wrote:
> From: Borislav Petkov
>
> There should be no functionality change resulting from this patch.
>
> diff --git a/arch/x86/kernel/head64.c b/arch/x86/kernel/head64.c
> index 068054f4bf20..eda1a865641e 100644
> --- a/arch/x86/kernel/hea
On Mon, 19 May 2014 20:27:32 +0200, Borislav Petkov said:
> From: Borislav Petkov
>
> ... instead of naked numbers.
>
> Stuff in sysrq.c used to set it to 8 which is supposed to mean above
> default level so set it to DEBUG instead as we're terminating/killing
> all tasks and we want to be verbose
On 05/19/2014 11:27 AM, Borislav Petkov wrote:
> From: Borislav Petkov
>
> ... instead of naked numbers.
>
> Stuff in sysrq.c used to set it to 8 which is supposed to mean above
> default level so set it to DEBUG instead as we're terminating/killing
> all tasks and we want to be verbose there.
>
On Mon, May 19, 2014 at 11:27 AM, Borislav Petkov wrote:
> From: Borislav Petkov
>
> ... instead of naked numbers.
>
> Stuff in sysrq.c used to set it to 8 which is supposed to mean above
> default level so set it to DEBUG instead as we're terminating/killing
> all tasks and we want to be verbose
On Mon, May 19, 2014 at 12:12:51PM -0700, Joe Perches wrote:
> On Mon, 2014-05-19 at 20:27 +0200, Borislav Petkov wrote:
> > ... instead of naked numbers.
>
> Seems sensible.
>
> > diff --git a/include/linux/printk.h b/include/linux/printk.h
> []
> > @@ -30,6 +30,17 @@ static inline const char *p
On Mon, 2014-05-19 at 20:27 +0200, Borislav Petkov wrote:
> ... instead of naked numbers.
Seems sensible.
> diff --git a/include/linux/printk.h b/include/linux/printk.h
[]
> @@ -30,6 +30,17 @@ static inline const char *printk_skip_level(const char
> *buffer)
> return buffer;
> }
>
> +/*
From: Borislav Petkov
... instead of naked numbers.
Stuff in sysrq.c used to set it to 8 which is supposed to mean above
default level so set it to DEBUG instead as we're terminating/killing
all tasks and we want to be verbose there.
There should be no functionality change resulting from this p
20 matches
Mail list logo
