Re: [PATCH] printk: avoid prb_first_valid_seq() where possible

2021-02-11 Thread Petr Mladek
On Wed 2021-02-10 19:32:10, John Ogness wrote: > On 2021-02-09, Petr Mladek wrote: > >> @@ -1629,9 +1631,13 @@ int do_syslog(int type, char __user *buf, int len, > >> int source) > >>/* Number of chars in the log buffer */ > >>case SYSLOG_ACTION_SIZE_UNREAD: > >>logbuf_lock_ir

Re: [PATCH] printk: avoid prb_first_valid_seq() where possible

2021-02-10 Thread John Ogness
On 2021-02-09, Petr Mladek wrote: >> @@ -1629,9 +1631,13 @@ int do_syslog(int type, char __user *buf, int len, >> int source) >> /* Number of chars in the log buffer */ >> case SYSLOG_ACTION_SIZE_UNREAD: >> logbuf_lock_irq(); >> -if (syslog_seq < prb_first_valid

Re: [PATCH] printk: avoid prb_first_valid_seq() where possible

2021-02-10 Thread John Ogness
On 2021-02-08, Sergey Senozhatsky wrote: >> Can we please also ask the kernel test robot to test this patch? Oliver Sang from LKP was able to verify that the RCU stall problem is not seen anymore on their side. See his response below. Thanks Oliver! John Ogness On 2021-02-10, Oliver Sang wrot

Re: [PATCH] printk: avoid prb_first_valid_seq() where possible

2021-02-09 Thread Petr Mladek
On Fri 2021-02-05 15:23:28, John Ogness wrote: > If message sizes average larger than expected (more than 32 > characters), the data_ring will wrap before the desc_ring. Once the > data_ring wraps, it will start invalidating descriptors. These > invalid descriptors hang around until they are eventu

Re: [PATCH] printk: avoid prb_first_valid_seq() where possible

2021-02-08 Thread Sergey Senozhatsky
On (21/02/05 15:23), John Ogness wrote: > If message sizes average larger than expected (more than 32 > characters), the data_ring will wrap before the desc_ring. Once the > data_ring wraps, it will start invalidating descriptors. These > invalid descriptors hang around until they are eventually re

Re: [PATCH] printk: avoid prb_first_valid_seq() where possible

2021-02-08 Thread J. Avila
Hello John, Thank you for looking into this! Yes, I can confirm that your patch seems to have resolved the issue I'd reported. Thanks, Avila On Mon, Feb 8, 2021 at 1:21 AM John Ogness wrote: > > On 2021-02-08, Sergey Senozhatsky wrote: > > Can we please also ask the kernel test robot to test

Re: [PATCH] printk: avoid prb_first_valid_seq() where possible

2021-02-08 Thread John Ogness
On 2021-02-08, Sergey Senozhatsky wrote: > Can we please also ask the kernel test robot to test this patch? LKP is an automated service. The problem was reported for an older commit. The new patch will not apply. I will try to contact the LKP team and see how we can get some sort of verification

Re: [PATCH] printk: avoid prb_first_valid_seq() where possible

2021-02-07 Thread Sergey Senozhatsky
On (21/02/05 15:23), John Ogness wrote: > If message sizes average larger than expected (more than 32 > characters), the data_ring will wrap before the desc_ring. Once the > data_ring wraps, it will start invalidating descriptors. These > invalid descriptors hang around until they are eventually re

[PATCH] printk: avoid prb_first_valid_seq() where possible

2021-02-05 Thread John Ogness
If message sizes average larger than expected (more than 32 characters), the data_ring will wrap before the desc_ring. Once the data_ring wraps, it will start invalidating descriptors. These invalid descriptors hang around until they are eventually recycled when the desc_ring wraps. Readers do not