Re: [PATCH] printk: fix integer overflow in setup_log_buf()

2018-10-12 Thread Petr Mladek
On Fri 2018-10-12 18:27:24, Sergey Senozhatsky wrote: > On (10/12/18 11:01), Petr Mladek wrote: > > > Make "free" unsigned integer and use appropriate printk() specifier. > > > > > > Signed-off-by: Sergey Senozhatsky > > > > I have pushed this fix into printk.git, for-4.20 branch. > > Thanks. >

Re: [PATCH] printk: fix integer overflow in setup_log_buf()

2018-10-12 Thread Sergey Senozhatsky
On (10/12/18 11:01), Petr Mladek wrote: > > Make "free" unsigned integer and use appropriate printk() specifier. > > > > Signed-off-by: Sergey Senozhatsky > > I have pushed this fix into printk.git, for-4.20 branch. Thanks. > Please note that this 2nd hunk was already part of the commit > e6fe

Re: [PATCH] printk: fix integer overflow in setup_log_buf()

2018-10-12 Thread Petr Mladek
On Wed 2018-10-10 20:33:08, Sergey Senozhatsky wrote: > The way we calculate logbuf free space percentage overflows signed > integer: > > int free; > > free = __LOG_BUF_LEN - log_next_idx; > pr_info("early log buf free: %u(%u%%)\n", > free, (free * 100) / __LOG_BUF

[PATCH] printk: fix integer overflow in setup_log_buf()

2018-10-10 Thread Sergey Senozhatsky
The way we calculate logbuf free space percentage overflows signed integer: int free; free = __LOG_BUF_LEN - log_next_idx; pr_info("early log buf free: %u(%u%%)\n", free, (free * 100) / __LOG_BUF_LEN); We support LOG_BUF_LEN of up to 1<<25 bytes. Since set

Re: [PATCH] printk: fix integer overflow in setup_log_buf()

2018-10-10 Thread Sergey Senozhatsky
On (10/10/18 19:38), Sergey Senozhatsky wrote: > The way we calculate free logbuf free space percentage > overflows signed integer: > > int free; > > free = __LOG_BUF_LEN - log_next_idx; > pr_info("early log buf free: %u(%u%%)\n", > free, (free * 100) / __LOG_BUF_L

[PATCH] printk: fix integer overflow in setup_log_buf()

2018-10-10 Thread Sergey Senozhatsky
The way we calculate free logbuf free space percentage overflows signed integer: int free; free = __LOG_BUF_LEN - log_next_idx; pr_info("early log buf free: %u(%u%%)\n", free, (free * 100) / __LOG_BUF_LEN); We support LOG_BUF_LEN of up to 2G, since setup_l