Re: [PATCH] printk: kmsg_dump: Mark registered flag as private

2019-03-12 Thread Ahmed S. Darwish
Hi, On Mon, Mar 11, 2019 at 09:49:05PM +0900, Sergey Senozhatsky wrote: > On (03/10/19 21:03), Ahmed S. Darwish wrote: > > The 'registered' flag is internally used by kmsg_dump_register() > > and kmsg_dump_unregister() to track multiple registrations of the > > same dumper. > > > > It's protected

Re: [PATCH] printk: kmsg_dump: Mark registered flag as private

2019-03-12 Thread Sergey Senozhatsky
On (03/12/19 10:18), Petr Mladek wrote: > > > * @max_reason: filter for highest reason number that should be dumped > > > - * @registered: Flag that specifies if this is already registered > > > + * @registered: Flag that specifies if this is already registered > > > (private) > > > */ > >

Re: [PATCH] printk: kmsg_dump: Mark registered flag as private

2019-03-12 Thread Petr Mladek
On Mon 2019-03-11 21:49:05, Sergey Senozhatsky wrote: > On (03/10/19 21:03), Ahmed S. Darwish wrote: > > The 'registered' flag is internally used by kmsg_dump_register() > > and kmsg_dump_unregister() to track multiple registrations of the > > same dumper. > > > > It's protected by printk's intern

Re: [PATCH] printk: kmsg_dump: Mark registered flag as private

2019-03-11 Thread Sergey Senozhatsky
On (03/10/19 21:03), Ahmed S. Darwish wrote: > The 'registered' flag is internally used by kmsg_dump_register() > and kmsg_dump_unregister() to track multiple registrations of the > same dumper. > > It's protected by printk's internal dump_list_lock, and must thus > be accessed only from there. Ma

[PATCH] printk: kmsg_dump: Mark registered flag as private

2019-03-10 Thread Ahmed S. Darwish
The 'registered' flag is internally used by kmsg_dump_register() and kmsg_dump_unregister() to track multiple registrations of the same dumper. It's protected by printk's internal dump_list_lock, and must thus be accessed only from there. Mark it as private. Signed-off-by: Ahmed S. Darwish ---