Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Wed 2017-08-23 21:36:21, Helge Deller wrote: > On 23.08.2017 16:49, Steven Rostedt wrote: > > On Wed, 23 Aug 2017 16:48:24 +0200 > > Petr Mladek wrote: > > > >> + > >> + printk("Going to call: %pF\n", gettimeofday); > >> + printk("Going to call: %pF\n", p->func); > >> +

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Wed 2017-08-23 21:36:21, Helge Deller wrote: > On 23.08.2017 16:49, Steven Rostedt wrote: > > On Wed, 23 Aug 2017 16:48:24 +0200 > > Petr Mladek wrote: > > > >> + > >> + printk("Going to call: %pF\n", gettimeofday); > >> + printk("Going to call: %pF\n", p->func); > >> + printk("%s: called

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Thu, 24 Aug 2017 09:41:03 +0900 Sergey Senozhatsky wrote: > On (08/23/17 16:48), Petr Mladek wrote: > [..] > > Sometimes people seems unclear when to use the %pS or %pF printk format. > > For example, see commit 51d96dc2e2dc ("random: fix warning message on

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Thu, 24 Aug 2017 09:41:03 +0900 Sergey Senozhatsky wrote: > On (08/23/17 16:48), Petr Mladek wrote: > [..] > > Sometimes people seems unclear when to use the %pS or %pF printk format. > > For example, see commit 51d96dc2e2dc ("random: fix warning message on ia64 > > and parisc") which fixed

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On (08/23/17 16:48), Petr Mladek wrote: [..] > Sometimes people seems unclear when to use the %pS or %pF printk format. > For example, see commit 51d96dc2e2dc ("random: fix warning message on ia64 > and parisc") which fixed such a wrong format string. > > The documentation should be more clear

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On (08/23/17 16:48), Petr Mladek wrote: [..] > Sometimes people seems unclear when to use the %pS or %pF printk format. > For example, see commit 51d96dc2e2dc ("random: fix warning message on ia64 > and parisc") which fixed such a wrong format string. > > The documentation should be more clear

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On 23.08.2017 16:49, Steven Rostedt wrote: > On Wed, 23 Aug 2017 16:48:24 +0200 > Petr Mladek wrote: > >> + >> +printk("Going to call: %pF\n", gettimeofday); >> +printk("Going to call: %pF\n", p->func); >> +printk("%s: called from %pS\n", __func__, _RET_IP_); >> +

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On 23.08.2017 16:49, Steven Rostedt wrote: > On Wed, 23 Aug 2017 16:48:24 +0200 > Petr Mladek wrote: > >> + >> +printk("Going to call: %pF\n", gettimeofday); >> +printk("Going to call: %pF\n", p->func); >> +printk("%s: called from %pS\n", __func__, _RET_IP_); >> +printk("%s:

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Wed, 23 Aug 2017 16:48:24 +0200 Petr Mladek wrote: > + > + printk("Going to call: %pF\n", gettimeofday); > + printk("Going to call: %pF\n", p->func); > + printk("%s: called from %pS\n", __func__, _RET_IP_); > + printk("%s: called from %pS\n", __func__,

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Wed, 23 Aug 2017 16:48:24 +0200 Petr Mladek wrote: > + > + printk("Going to call: %pF\n", gettimeofday); > + printk("Going to call: %pF\n", p->func); > + printk("%s: called from %pS\n", __func__, _RET_IP_); > + printk("%s: called from %pS\n", __func__,

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Tue 2017-08-15 21:58:33, Helge Deller wrote: > On 15.08.2017 13:36, Petr Mladek wrote: > > Here is the updated patch with my proposed changes. > > Feel free to update it: > > Much better! > Thanks a lot. > > Maybe we should mention usage of __func__ with '%s' (see other thread). > > And

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Tue 2017-08-15 21:58:33, Helge Deller wrote: > On 15.08.2017 13:36, Petr Mladek wrote: > > Here is the updated patch with my proposed changes. > > Feel free to update it: > > Much better! > Thanks a lot. > > Maybe we should mention usage of __func__ with '%s' (see other thread). > > And

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

Hello, sorry for the delay. On (08/15/17 13:36), Petr Mladek wrote: [..] > > Experts surely do know what function descriptors are. > > Nevertheless even those often get it wrong as can be seen in > > various commits. > > It seems that these specifiers are used the wrong way on many > locations.

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

Hello, sorry for the delay. On (08/15/17 13:36), Petr Mladek wrote: [..] > > Experts surely do know what function descriptors are. > > Nevertheless even those often get it wrong as can be seen in > > various commits. > > It seems that these specifiers are used the wrong way on many > locations.

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Tue, 15 Aug 2017 21:47:27 +0200 Helge Deller wrote: > > Very interesting! > > > > This code: > > void smp_cpus_done() { > > printk("Called from %pF.\n", smp_cpus_done); > > printk("Called from %pf.\n", smp_cpus_done); > > printk("Called in %pS.\n", __func__); > >

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Tue, 15 Aug 2017 21:47:27 +0200 Helge Deller wrote: > > Very interesting! > > > > This code: > > void smp_cpus_done() { > > printk("Called from %pF.\n", smp_cpus_done); > > printk("Called from %pf.\n", smp_cpus_done); > > printk("Called in %pS.\n", __func__); > > printk("Called in %ps.\n",

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On 15.08.2017 13:36, Petr Mladek wrote: > On Fri 2017-08-11 09:31:28, Helge Deller wrote: >> On 11.08.2017 02:15, Sergey Senozhatsky wrote: >>> On (08/10/17 19:35), Helge Deller wrote: Sometimes people seems unclear when to use the %pS or %pF printk format. Adding some examples may help

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On 15.08.2017 13:36, Petr Mladek wrote: > On Fri 2017-08-11 09:31:28, Helge Deller wrote: >> On 11.08.2017 02:15, Sergey Senozhatsky wrote: >>> On (08/10/17 19:35), Helge Deller wrote: Sometimes people seems unclear when to use the %pS or %pF printk format. Adding some examples may help

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On 15.08.2017 21:41, Helge Deller wrote: > On 15.08.2017 14:46, Steven Rostedt wrote: >> On Thu, 10 Aug 2017 19:35:33 +0200 >> Helge Deller wrote: >> >>> Sometimes people seems unclear when to use the %pS or %pF printk format. >>> Adding some examples may help to avoid such

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On 15.08.2017 21:41, Helge Deller wrote: > On 15.08.2017 14:46, Steven Rostedt wrote: >> On Thu, 10 Aug 2017 19:35:33 +0200 >> Helge Deller wrote: >> >>> Sometimes people seems unclear when to use the %pS or %pF printk format. >>> Adding some examples may help to avoid such mistakes. >>> >>> See

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On 15.08.2017 14:46, Steven Rostedt wrote: > On Thu, 10 Aug 2017 19:35:33 +0200 > Helge Deller wrote: > >> Sometimes people seems unclear when to use the %pS or %pF printk format. >> Adding some examples may help to avoid such mistakes. >> >> See for example commit 51d96dc2e2dc

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On 15.08.2017 14:46, Steven Rostedt wrote: > On Thu, 10 Aug 2017 19:35:33 +0200 > Helge Deller wrote: > >> Sometimes people seems unclear when to use the %pS or %pF printk format. >> Adding some examples may help to avoid such mistakes. >> >> See for example commit 51d96dc2e2dc ("random: fix

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Thu, 10 Aug 2017 19:35:33 +0200 Helge Deller wrote: > Sometimes people seems unclear when to use the %pS or %pF printk format. > Adding some examples may help to avoid such mistakes. > > See for example commit 51d96dc2e2dc ("random: fix warning message on ia64 and > parisc")

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Thu, 10 Aug 2017 19:35:33 +0200 Helge Deller wrote: > Sometimes people seems unclear when to use the %pS or %pF printk format. > Adding some examples may help to avoid such mistakes. > > See for example commit 51d96dc2e2dc ("random: fix warning message on ia64 and > parisc") which fixed such

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Fri 2017-08-11 09:31:28, Helge Deller wrote: > On 11.08.2017 02:15, Sergey Senozhatsky wrote: > > On (08/10/17 19:35), Helge Deller wrote: > >> Sometimes people seems unclear when to use the %pS or %pF printk format. > >> Adding some examples may help to avoid such mistakes. > >> > >> See for

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On Fri 2017-08-11 09:31:28, Helge Deller wrote: > On 11.08.2017 02:15, Sergey Senozhatsky wrote: > > On (08/10/17 19:35), Helge Deller wrote: > >> Sometimes people seems unclear when to use the %pS or %pF printk format. > >> Adding some examples may help to avoid such mistakes. > >> > >> See for

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On 11.08.2017 02:15, Sergey Senozhatsky wrote: > On (08/10/17 19:35), Helge Deller wrote: >> Sometimes people seems unclear when to use the %pS or %pF printk format. >> Adding some examples may help to avoid such mistakes. >> >> See for example commit 51d96dc2e2dc ("random: fix warning message on

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On 11.08.2017 02:15, Sergey Senozhatsky wrote: > On (08/10/17 19:35), Helge Deller wrote: >> Sometimes people seems unclear when to use the %pS or %pF printk format. >> Adding some examples may help to avoid such mistakes. >> >> See for example commit 51d96dc2e2dc ("random: fix warning message on

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On (08/10/17 19:35), Helge Deller wrote: > Sometimes people seems unclear when to use the %pS or %pF printk format. > Adding some examples may help to avoid such mistakes. > > See for example commit 51d96dc2e2dc ("random: fix warning message on ia64 and > parisc") which fixed such a wrong format

Re: [PATCH] printk-formats.txt: Add examples for %pS and %pF

On (08/10/17 19:35), Helge Deller wrote: > Sometimes people seems unclear when to use the %pS or %pF printk format. > Adding some examples may help to avoid such mistakes. > > See for example commit 51d96dc2e2dc ("random: fix warning message on ia64 and > parisc") which fixed such a wrong format

[PATCH] printk-formats.txt: Add examples for %pS and %pF

Sometimes people seems unclear when to use the %pS or %pF printk format. Adding some examples may help to avoid such mistakes. See for example commit 51d96dc2e2dc ("random: fix warning message on ia64 and parisc") which fixed such a wrong format string. Signed-off-by: Helge Deller

[PATCH] printk-formats.txt: Add examples for %pS and %pF

Sometimes people seems unclear when to use the %pS or %pF printk format. Adding some examples may help to avoid such mistakes. See for example commit 51d96dc2e2dc ("random: fix warning message on ia64 and parisc") which fixed such a wrong format string. Signed-off-by: Helge Deller diff --git