On Wed 2017-08-23 21:36:21, Helge Deller wrote:
> On 23.08.2017 16:49, Steven Rostedt wrote:
> > On Wed, 23 Aug 2017 16:48:24 +0200
> > Petr Mladek wrote:
> >
> >> +
> >> + printk("Going to call: %pF\n", gettimeofday);
> >> + printk("Going to call: %pF\n", p->func);
> >> + printk("%s: called f
On Thu, 24 Aug 2017 09:41:03 +0900
Sergey Senozhatsky wrote:
> On (08/23/17 16:48), Petr Mladek wrote:
> [..]
> > Sometimes people seems unclear when to use the %pS or %pF printk format.
> > For example, see commit 51d96dc2e2dc ("random: fix warning message on ia64
> > and parisc") which fixed su
On (08/23/17 16:48), Petr Mladek wrote:
[..]
> Sometimes people seems unclear when to use the %pS or %pF printk format.
> For example, see commit 51d96dc2e2dc ("random: fix warning message on ia64
> and parisc") which fixed such a wrong format string.
>
> The documentation should be more clear abo
On 23.08.2017 16:49, Steven Rostedt wrote:
> On Wed, 23 Aug 2017 16:48:24 +0200
> Petr Mladek wrote:
>
>> +
>> +printk("Going to call: %pF\n", gettimeofday);
>> +printk("Going to call: %pF\n", p->func);
>> +printk("%s: called from %pS\n", __func__, _RET_IP_);
>> +printk("%s: calle
On Wed, 23 Aug 2017 16:48:24 +0200
Petr Mladek wrote:
> +
> + printk("Going to call: %pF\n", gettimeofday);
> + printk("Going to call: %pF\n", p->func);
> + printk("%s: called from %pS\n", __func__, _RET_IP_);
> + printk("%s: called from %pS\n", __func__, __builtin_return_address(
On Tue 2017-08-15 21:58:33, Helge Deller wrote:
> On 15.08.2017 13:36, Petr Mladek wrote:
> > Here is the updated patch with my proposed changes.
> > Feel free to update it:
>
> Much better!
> Thanks a lot.
>
> Maybe we should mention usage of __func__ with '%s' (see other thread).
>
> And _RET_
Hello,
sorry for the delay.
On (08/15/17 13:36), Petr Mladek wrote:
[..]
> > Experts surely do know what function descriptors are.
> > Nevertheless even those often get it wrong as can be seen in
> > various commits.
>
> It seems that these specifiers are used the wrong way on many
> locations.
On Tue, 15 Aug 2017 21:47:27 +0200
Helge Deller wrote:
> > Very interesting!
> >
> > This code:
> > void smp_cpus_done() {
> > printk("Called from %pF.\n", smp_cpus_done);
> > printk("Called from %pf.\n", smp_cpus_done);
> > printk("Called in %pS.\n", __func__);
> > printk("Called in %ps.\n", __
On 15.08.2017 13:36, Petr Mladek wrote:
> On Fri 2017-08-11 09:31:28, Helge Deller wrote:
>> On 11.08.2017 02:15, Sergey Senozhatsky wrote:
>>> On (08/10/17 19:35), Helge Deller wrote:
Sometimes people seems unclear when to use the %pS or %pF printk format.
Adding some examples may help t
On 15.08.2017 21:41, Helge Deller wrote:
> On 15.08.2017 14:46, Steven Rostedt wrote:
>> On Thu, 10 Aug 2017 19:35:33 +0200
>> Helge Deller wrote:
>>
>>> Sometimes people seems unclear when to use the %pS or %pF printk format.
>>> Adding some examples may help to avoid such mistakes.
>>>
>>> See f
On 15.08.2017 14:46, Steven Rostedt wrote:
> On Thu, 10 Aug 2017 19:35:33 +0200
> Helge Deller wrote:
>
>> Sometimes people seems unclear when to use the %pS or %pF printk format.
>> Adding some examples may help to avoid such mistakes.
>>
>> See for example commit 51d96dc2e2dc ("random: fix warn
On Thu, 10 Aug 2017 19:35:33 +0200
Helge Deller wrote:
> Sometimes people seems unclear when to use the %pS or %pF printk format.
> Adding some examples may help to avoid such mistakes.
>
> See for example commit 51d96dc2e2dc ("random: fix warning message on ia64 and
> parisc") which fixed such
On Fri 2017-08-11 09:31:28, Helge Deller wrote:
> On 11.08.2017 02:15, Sergey Senozhatsky wrote:
> > On (08/10/17 19:35), Helge Deller wrote:
> >> Sometimes people seems unclear when to use the %pS or %pF printk format.
> >> Adding some examples may help to avoid such mistakes.
> >>
> >> See for ex
On 11.08.2017 02:15, Sergey Senozhatsky wrote:
> On (08/10/17 19:35), Helge Deller wrote:
>> Sometimes people seems unclear when to use the %pS or %pF printk format.
>> Adding some examples may help to avoid such mistakes.
>>
>> See for example commit 51d96dc2e2dc ("random: fix warning message on i
On (08/10/17 19:35), Helge Deller wrote:
> Sometimes people seems unclear when to use the %pS or %pF printk format.
> Adding some examples may help to avoid such mistakes.
>
> See for example commit 51d96dc2e2dc ("random: fix warning message on ia64 and
> parisc") which fixed such a wrong format s
Sometimes people seems unclear when to use the %pS or %pF printk format.
Adding some examples may help to avoid such mistakes.
See for example commit 51d96dc2e2dc ("random: fix warning message on ia64 and
parisc") which fixed such a wrong format string.
Signed-off-by: Helge Deller
diff --git a/
16 matches
Mail list logo